This is an archive of the discontinued LLVM Phabricator instance.

[runtimes] Don't use -Wall on clang-cl builds
ClosedPublic

Authored by philnik on Mar 19 2023, 2:16 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Restricted Project
Commits
rGe6cc0faa7382: [runtimes] Don't use -Wall on clang-cl builds
Summary

-Wall on clang-cl is equivalent to -Weverything on clang. We already add the correct warning flag depending whether we are in an MSVC-like environment, so just remove it from the list of flags that get passed unconditionally.

Diff Detail

Event Timeline

philnik created this revision.Mar 19 2023, 2:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2023, 2:16 AM
philnik requested review of this revision.Mar 19 2023, 2:16 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 19 2023, 2:16 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik updated this revision to Diff 506369.Mar 19 2023, 2:48 AM

Other fix

philnik retitled this revision from [runtimes] Disable -Wreserved-identitifer on clang-cl builds to [runtimes] Don't use -Wall on clang-cl builds.Mar 19 2023, 2:51 AM
philnik edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Mar 19 2023, 4:51 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.