Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D146361

[libc++][Apple] Make sure to set the LIBCXX_LIBRARY_VERSION when building for Apple
ClosedPublic
Actions

Authored by ldionne on Mar 18 2023, 9:10 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGd6c12cbee314: [libc++][Apple] Make sure to set the LIBCXX_LIBRARY_VERSION when building for…

Diff Detail

Unit TestsFailed
View All

TimeTest
280 mslibcxx CI No exceptions > llvm-libc++-shared-cfg-in.std/language_support/support_dynamic/new_delete/new_delete_array::new_align_val_t_nothrow.pass.cpp
270 mslibcxx CI No exceptions > llvm-libc++-shared-cfg-in.std/language_support/support_dynamic/new_delete/new_delete_array::new_array_nothrow.pass.cpp
300 mslibcxx CI No exceptions > llvm-libc++-shared-cfg-in.std/language_support/support_dynamic/new_delete/new_delete_single::new_align_val_t_nothrow.pass.cpp
280 mslibcxx CI No exceptions > llvm-libc++-shared-cfg-in.std/language_support/support_dynamic/new_delete/new_delete_single::new_nothrow.pass.cpp

Event Timeline

ldionne created this revision.Mar 18 2023, 9:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2023, 9:10 AM
Herald added subscribers: mikhail.ramalho, arichardson. · View Herald Transcript
ldionne requested review of this revision.Mar 18 2023, 9:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2023, 9:10 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B220225: Diff 506300.Mar 18 2023, 1:21 PM
ldionne accepted this revision.Mar 18 2023, 1:21 PM

CI failures are unrelated.

This revision is now accepted and ready to land.Mar 18 2023, 1:21 PM
This revision was landed with ongoing or failed builds.Mar 18 2023, 1:22 PM
Closed by commit rGd6c12cbee314: [libc++][Apple] Make sure to set the LIBCXX_LIBRARY_VERSION when building for… (authored by ldionne). · Explain Why
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rGd6c12cbee314: [libc++][Apple] Make sure to set the LIBCXX_LIBRARY_VERSION when building for….

Revision Contents
Changeset List

PathSize
libcxx/
utils/
ci/
3 lines

Diff 506300

View Options

libcxx/utils/ci/apple-install-libcxx.sh

Loading...