Page MenuHomePhabricator
Differential D146227

[libc++] Use the _LIBCPP_VERBOSE_ABORT macro instead of calling the function directly
ClosedPublic
Actions

Authored by philnik on Thu, Mar 16, 7:07 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG308bcb3f7bab: [libc++] Use the _LIBCPP_VERBOSE_ABORT macro instead of calling the function…
Summary

These calls were added in D141222.

Diff Detail

Event Timeline

philnik created this revision.Thu, Mar 16, 7:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Mar 16, 7:07 AM
Herald added subscribers: mikhail.ramalho, smeenai. · View Herald Transcript
philnik requested review of this revision.Thu, Mar 16, 7:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Mar 16, 7:07 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne accepted this revision.Thu, Mar 16, 7:11 AM
ldionne added a subscriber: ldionne.

Thanks for the catch.

This revision is now accepted and ready to land.Thu, Mar 16, 7:11 AM
Harbormaster completed remote builds in B219862: Diff 505799.Thu, Mar 16, 8:36 AM
philnik updated this revision to Diff 505898.Thu, Mar 16, 12:16 PM

Try to fix CI

Harbormaster completed remote builds in B219934: Diff 505898.Thu, Mar 16, 1:48 PM
philnik updated this revision to Diff 505953.Thu, Mar 16, 4:35 PM

Try to fix CI

Harbormaster completed remote builds in B219973: Diff 505953.Thu, Mar 16, 5:00 PM
philnik updated this revision to Diff 505962.Thu, Mar 16, 6:00 PM

Next try

Harbormaster completed remote builds in B219981: Diff 505962.Thu, Mar 16, 8:41 PM
smeenai mentioned this in D141222: [libc++] Use __verbose_abort instead of std::abort in __throw_ functions.Fri, Mar 17, 1:53 PM
This revision was landed with ongoing or failed builds.Fri, Mar 17, 4:34 PM
Closed by commit rG308bcb3f7bab: [libc++] Use the _LIBCPP_VERBOSE_ABORT macro instead of calling the function… (authored by philnik). · Explain Why
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rG308bcb3f7bab: [libc++] Use the _LIBCPP_VERBOSE_ABORT macro instead of calling the function….

Revision Contents
Changeset List

PathSize
libcxx/
include/
__expected/
2 lines
__filesystem/
2 lines
__functional/
2 lines
__memory/
2 lines
3 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
16 lines
2 lines
2 lines

Diff 506222

View Options

libcxx/include/__expected/expected.h

Loading...
View Options

libcxx/include/__filesystem/filesystem_error.h

Loading...
View Options

libcxx/include/__functional/function.h

Loading...
View Options

libcxx/include/__memory/shared_ptr.h

Loading...
View Options

libcxx/include/__verbose_abort

Loading...
View Options

libcxx/include/any

Loading...
View Options

libcxx/include/future

Loading...
View Options

libcxx/include/ios

Loading...
View Options

libcxx/include/new

Loading...
View Options

libcxx/include/optional

Loading...
View Options

libcxx/include/regex

Loading...
View Options

libcxx/include/stdexcept

Loading...
View Options

libcxx/include/typeinfo

Loading...
View Options

libcxx/include/variant

Loading...