This is an archive of the discontinued LLVM Phabricator instance.

[docs] Document MemProf metadata in LangRef
ClosedPublic

Authored by tejohnson on Mar 13 2023, 8:31 PM.

Details

Summary

Add documentation for memprof and callsite metadata in LangRef.

Diff Detail

Event Timeline

tejohnson created this revision.Mar 13 2023, 8:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 8:31 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript
tejohnson requested review of this revision.Mar 13 2023, 8:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 8:31 PM
snehasish accepted this revision.Mar 14 2023, 10:37 AM

lgtm, thanks for documenting the metadata format.

llvm/docs/LangRef.rst
7483

s/profile/profiled ?

7486

"... and one allocating ..."

7496

Perhaps hyphenated "leaf-most" is clearer? Another occurrence below if you choose to change it.

7499

"the profiled callstack" to make it clearer?

7511

s/on/in?

This revision is now accepted and ready to land.Mar 14 2023, 10:37 AM
tejohnson marked 5 inline comments as done.Mar 14 2023, 11:03 AM
This revision was automatically updated to reflect the committed changes.