This is an archive of the discontinued LLVM Phabricator instance.

Differential D145612

[lldb] Only replace valobj with persisted one if not null in DWIMPrint
ClosedPublic

Authored by augusto2112 on Mar 8 2023, 1:43 PM.

Details

Reviewers
kastiglione
Commits
rG581ac50d58b9: [lldb] Only replace valobj with persisted one if not null in DWIMPrint

Diff Detail

Event Timeline

augusto2112 created this revision.Mar 8 2023, 1:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2023, 1:43 PM
augusto2112 requested review of this revision.Mar 8 2023, 1:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2023, 1:43 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B218201: Diff 503503.Mar 8 2023, 1:46 PM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptMar 8 2023, 1:46 PM
kastiglione accepted this revision.Mar 8 2023, 2:14 PM

thank you

lldb/source/Commands/CommandObjectDWIMPrint.cpp
92–94
This revision is now accepted and ready to land.Mar 8 2023, 2:14 PM
Closed by commit rG581ac50d58b9: [lldb] Only replace valobj with persisted one if not null in DWIMPrint (authored by augusto2112). · Explain WhyMar 8 2023, 2:19 PM
This revision was automatically updated to reflect the committed changes.
augusto2112 added a commit: rG581ac50d58b9: [lldb] Only replace valobj with persisted one if not null in DWIMPrint.

Revision Contents

PathSize
lldb/
source/
Commands/
6 lines

Diff 503518

lldb/source/Commands/CommandObjectDWIMPrint.cpp

Show First 20 Lines • Show All 82 Lines • ▼ Show 20 Linesbool CommandObjectDWIMPrint::DoExecute(StringRef command,
DumpValueObjectOptions dump_options = m_varobj_options.GetAsDumpOptions( DumpValueObjectOptions dump_options = m_varobj_options.GetAsDumpOptions(
m_expr_options.m_verbosity, m_format_options.GetFormat()); m_expr_options.m_verbosity, m_format_options.GetFormat());
dump_options.SetHideName(eval_options.GetSuppressPersistentResult()); dump_options.SetHideName(eval_options.GetSuppressPersistentResult());
// First, try `expr` as the name of a frame variable. // First, try `expr` as the name of a frame variable.
if (StackFrame *frame = m_exe_ctx.GetFramePtr()) { if (StackFrame *frame = m_exe_ctx.GetFramePtr()) {
auto valobj_sp = frame->FindVariable(ConstString(expr)); auto valobj_sp = frame->FindVariable(ConstString(expr));
if (valobj_sp && valobj_sp->GetError().Success()) { if (valobj_sp && valobj_sp->GetError().Success()) {
if (!eval_options.GetSuppressPersistentResult()) if (!eval_options.GetSuppressPersistentResult()) {
valobj_sp = valobj_sp->Persist(); if (auto persisted_valobj = valobj_sp->Persist())
valobj_sp = persisted_valobj;
}
kastiglioneUnsubmitted
Not Done
ReplyInline Actions
if (!eval_options.GetSuppressPersistentResult()) {
- auto persisted_valobj = valobj_sp->Persist();
- if (persisted_valobj)
+ if (auto persisted_valobj = valobj_sp->Persist())
valobj_sp = persisted_valobj;
}
if (verbosity == eDWIMPrintVerbosityFull) {
kastiglione:
if (verbosity == eDWIMPrintVerbosityFull) { if (verbosity == eDWIMPrintVerbosityFull) {
StringRef flags; StringRef flags;
if (args.HasArgs()) if (args.HasArgs())
flags = args.GetArgString(); flags = args.GetArgString();
result.AppendMessageWithFormatv("note: ran `frame variable {0}{1}`", result.AppendMessageWithFormatv("note: ran `frame variable {0}{1}`",
flags, expr); flags, expr);
} }
Show All 35 Lines