This is an archive of the discontinued LLVM Phabricator instance.

Fix LLDB windows build
ClosedPublic

Authored by omjavaid on Mar 6 2023, 3:53 PM.

Details

Summary

LLDB WoA buildbot is failing due to pid_t redefinition after recent changes in lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp.
Process.h includes PosixApi.h which defines pid_t. Python.h on windows also typedefs
pid_t. To make sure that we include Python.h before PosixApi this patch renforces
the workaround previously set up to guard this issue.

https://lab.llvm.org/buildbot/#/builders/219

Diff Detail

Event Timeline

omjavaid created this revision.Mar 6 2023, 3:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2023, 3:53 PM
Herald added a subscriber: mstorsjo. · View Herald Transcript
omjavaid requested review of this revision.Mar 6 2023, 3:53 PM
mib accepted this revision.Mar 6 2023, 4:20 PM
This revision is now accepted and ready to land.Mar 6 2023, 4:20 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2023, 5:38 PM