This is an archive of the discontinued LLVM Phabricator instance.

Differential D14540

clang-tidy: Fix FP in MacroParenthesesChecker when using object member pointer
ClosedPublic

Authored by danielmarjamaki on Nov 10 2015, 4:59 AM.

Details

Reviewers
alexfh
Summary

This patch fixes the FP in http://llvm.org/PR25208

Diff Detail

Event Timeline

danielmarjamaki updated this revision to Diff 39805.Nov 10 2015, 4:59 AM
danielmarjamaki retitled this revision from to clang-tidy: Fix FP in MacroParenthesesChecker when using object member pointer.
danielmarjamaki updated this object.
danielmarjamaki added a reviewer: alexfh.
danielmarjamaki updated this object.
danielmarjamaki added a subscriber: cfe-commits.
alexfh accepted this revision.Nov 10 2015, 5:50 AM
alexfh edited edge metadata.

Looks good. Thank you for the fix!

This revision is now accepted and ready to land.Nov 10 2015, 5:50 AM
danielmarjamaki closed this revision.Nov 10 2015, 6:40 AM

Committed with 252608

Revision Contents

PathSize
clang-tidy/
misc/
3 lines
test/
clang-tidy/
2 lines

Diff 39805

clang-tidy/misc/MacroParenthesesCheck.cpp

Show First 20 Lines • Show All 142 Lines • ▼ Show 20 Lines for (auto TI = MI->tokens_begin(), TE = MI->tokens_end(); TI != TE; ++TI) {
if (isSurroundedLeft(Prev) && isSurroundedRight(Next)) if (isSurroundedLeft(Prev) && isSurroundedRight(Next))
continue; continue;
// Don't warn after hash/hashhash or before hashhash. // Don't warn after hash/hashhash or before hashhash.
if (Prev.isOneOf(tok::hash, tok::hashhash) || Next.is(tok::hashhash)) if (Prev.isOneOf(tok::hash, tok::hashhash) || Next.is(tok::hashhash))
continue; continue;
// Argument is a struct member. // Argument is a struct member.
if (Prev.isOneOf(tok::period, tok::arrow, tok::coloncolon)) if (Prev.isOneOf(tok::period, tok::arrow, tok::coloncolon, tok::arrowstar,
tok::periodstar))
continue; continue;
// Argument is a namespace or class. // Argument is a namespace or class.
if (Next.is(tok::coloncolon)) if (Next.is(tok::coloncolon))
continue; continue;
// String concatenation. // String concatenation.
if (isStringLiteral(Prev.getKind()) || isStringLiteral(Next.getKind())) if (isStringLiteral(Prev.getKind()) || isStringLiteral(Next.getKind()))
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines

test/clang-tidy/misc-macro-parentheses.cpp

Show All 28 Lines
#define GOOD18(x) ;x; #define GOOD18(x) ;x;
#define GOOD19 ;-2; #define GOOD19 ;-2;
#define GOOD20 void* #define GOOD20 void*
#define GOOD21(a) case Fred::a: #define GOOD21(a) case Fred::a:
#define GOOD22(a) if (verbose) return a; #define GOOD22(a) if (verbose) return a;
#define GOOD23(type) (type::Field) #define GOOD23(type) (type::Field)
#define GOOD24(t) std::set<t> s #define GOOD24(t) std::set<t> s
#define GOOD25(t) std::set<t,t,t> s #define GOOD25(t) std::set<t,t,t> s
#define GOOD26(x) (a->*x)
#define GOOD27(x) (a.*x)
// These are allowed for now.. // These are allowed for now..
#define MAYBE1 *12.34 #define MAYBE1 *12.34
#define MAYBE2 <<3 #define MAYBE2 <<3