User Details
- User Since
- Mar 3 2015, 10:32 PM (382 w, 2 d)
Jan 7 2021
Typically in such cases bug visitors should be added/improved until it is clear from the user-facing report why does the analyzer think so. They'd highlight the important events, prevent path pruning, and potentially suppress reports if the reason is discovered to not be valid.
Jan 6 2021
I have run clang static analysis on random open source projects. The very first finding that I look at seems (to me) to be a false positive. :-(
I also agree with @NoQ's D92634#2478703 comment.
Jan 5 2021
BTW, I cannot optimize function f to returning zero directly with GCC-10.2.1 and Clang-10.0.1 under -O3. Should I add any other flags? Or it is version specific?
Jan 4 2021
However, the mainstream compilers like GCC and Clang implement this as the overflowed value, and some programmers also use this feature to do some tricky things.
Jan 2 2021
Besides, the return value should be the exact value computed from the two integers, even unknown, rather than undefined. As the developers may overflow an integer on purpose.
Jan 1 2021
ok.. thanks for the reviews. I will see if I can make some new check.
Dec 14 2020
No reviews => I will not contribute.
Dec 3 2020
Jan 15 2018
Erik and I will not continue working on this. Feel free to take over the patch or write a new patch.
I will not continue working on this. Feel free to take over the patch or write a new patch.
I will not continue working on this. Feel free to take over the patch or write a new patch.
I will not continue working on this. Feel free to take over the patch or write a new patch.
I will not continue working on this. Feel free to take over the patch or write a new patch.
Nov 17 2017
> So what are the arguments that are passed to getSimplifiedOffset() in that case? 0? That does not seem to be correct.
Nov 15 2017
Could you do a similar analysis that I did above to check why does this not work for the multidimensional case? (I.e.: checking what constraints are generated and what the analyzer does with them.)
Nov 6 2017
I have updated the patch so it uses evalBinOpNN. This seems to work properly.
Oct 26 2017
Do you mind writing some tests with multidimensional arrays to check what do we lose if we remove that code?
Oct 19 2017
As suggested, use a ProgramState trait to detect VLA overflows.
I think it is much better when the assert failure tells the developer _what_ value is failing, rather than saying "oops we are dead".
I like this patch overall.. here are some stylistic nits.
Stylistically this looks pretty good to me. Just a minor nit.
Oct 18 2017
Oct 16 2017
LGTM
LGTM.. however I would like approval from somebody else also.
ping
Oct 13 2017
Track modification of global static variables in CallGraph construction
Oct 12 2017
Oct 11 2017
Oct 10 2017
ping
LGTM! However I would like to see a review from somebody else also.
I think a test for -Wtautological-pointer-compare should be added that shows that the bug is fixed.
Oct 9 2017
LGTM
However, the checker seems to work with a low false positive rate. (<15 on the LLVM, 6 effectively different)
Oct 6 2017
Fixes according to review comments. Reuse ast matchers in LoopUnrolling.cpp. Avoid some recursion (however the isChanged() is still recursive but it is very small and simple).
Oct 4 2017
ping
ping
Sep 29 2017
Sep 27 2017
fixed review comments
Sep 25 2017
ping
Sep 15 2017
Minor cleanups. Changed names. Updated comments.
Sep 14 2017
ping
ping
Sep 6 2017
This is not committed as far as I see.. do you have write permission or do you want that I commit it?
minor code cleanup
ping
Sep 1 2017
Aug 31 2017
small nits
ping
Aug 28 2017
Aug 23 2017
ping
Aug 14 2017
LGTM. But others should approve.
LGTM. I let others approve this.
Aug 9 2017
Should evalAPSInt() have machinery to do standard sign/type promotions? I suggest that I add one more argument bool promote = false, do you think that sounds good?
Refactoring, use BasicValueFactory::evalAPSInt
Aug 8 2017
A minor code cleanup. No functional change.
Aug 3 2017
Cleaned up the patch a little. Thanks Gabor for telling me about SValBuilder::getKnownValue()
Aug 2 2017
Aug 1 2017
Jun 22 2017
Fix review comments
Jun 19 2017
I will not continue working on this checker
May 26 2017
ping
ping
May 16 2017
Fix review comments
May 15 2017
renamed exprComparesTo to svalComparesTo
minor tweak
May 2 2017
Apr 27 2017
Apr 25 2017
If you have svn write permission then please do it.
Ping.
Ping. Any comments?
Ping
I am thinking about making my check more strict so it only warns in allocations. I believe the example code is much more motivating when there is allocation.
Fixed review comments. Made code examples and documentation more motivational.