This is an archive of the discontinued LLVM Phabricator instance.

[Tooling/Inclusion] Add missing index_sequence symbols.
ClosedPublic

Authored by hokein on Mar 6 2023, 3:08 AM.

Diff Detail

Event Timeline

hokein created this revision.Mar 6 2023, 3:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2023, 3:08 AM
Herald added a subscriber: arphaman. · View Herald Transcript
hokein requested review of this revision.Mar 6 2023, 3:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2023, 3:08 AM
hokein added inline comments.Mar 6 2023, 3:09 AM
clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc
251

I have updated the cppreference symbol page, now it has entries for these four symbols.

kadircet added inline comments.Mar 6 2023, 4:13 AM
clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc
252

there's also integer_sequence see https://eel.is/c++draft/utility.syn

hokein added inline comments.Mar 6 2023, 4:37 AM
clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc
252

The integer_sequence has been indexed in the symbol page, it is already in StdSymbolMap.inc, https://github.com/llvm/llvm-project/blob/main/clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc#L1576

kadircet accepted this revision.Mar 6 2023, 4:50 AM
kadircet added inline comments.
clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc
252

oops, thanks!

This revision is now accepted and ready to land.Mar 6 2023, 4:50 AM
This revision was automatically updated to reflect the committed changes.