This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Temporarily disable GetRssFromBuffer test
ClosedPublic

Authored by Chia-hungDuan on Mar 1 2023, 3:46 PM.

Details

Summary

This is a flaky test and may not test the thing it expected to verify.
E.g., it doesn't dirty the pages so the memory usage may not be reflected
on the RSS.

Diff Detail

Event Timeline

Chia-hungDuan created this revision.Mar 1 2023, 3:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 3:46 PM
Chia-hungDuan requested review of this revision.Mar 1 2023, 3:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 3:46 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Chia-hungDuan edited the summary of this revision. (Show Details)
cferris accepted this revision.Mar 1 2023, 3:59 PM

Unfortunately, this test probably needs to be rewritten. If you want to keep this test, it would be best to fork/exec and use mmap to grab some memory, touch at least one byte in every page of the allocation, then do the GetRSS() call, then munmap the memory. That would be the best way to guarantee a stable change to the RSS that can be used to verify GetRSS is working correctly.

This revision is now accepted and ready to land.Mar 1 2023, 3:59 PM
This revision was automatically updated to reflect the committed changes.