This is an archive of the discontinued LLVM Phabricator instance.

[memprof] Avoid meaningless pod copy
ClosedPublic

Authored by yingcong-wu on Feb 28 2023, 7:36 PM.

Details

Summary

The pointer Buffer is not changed, so there is no need to use reference, and the Pod here should use reference to avoid meaningless copy.

Diff Detail

Event Timeline

yingcong-wu created this revision.Feb 28 2023, 7:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2023, 7:36 PM
Herald added a subscriber: Enna1. · View Herald Transcript
yingcong-wu requested review of this revision.Feb 28 2023, 7:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2023, 7:36 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
yingcong-wu retitled this revision from avoid meaningless pod copy to [memprof] avoid meaningless pod copy.Feb 28 2023, 7:59 PM
yingcong-wu edited the summary of this revision. (Show Details)
yingcong-wu added a reviewer: snehasish.
yingcong-wu abandoned this revision.Feb 28 2023, 8:03 PM
yingcong-wu reclaimed this revision.Feb 28 2023, 9:20 PM

add const to pod

yingcong-wu retitled this revision from [memprof] avoid meaningless pod copy to [memprof] Avoid meaningless pod copy.Feb 28 2023, 9:28 PM
yingcong-wu added a reviewer: davidxl.
snehasish accepted this revision.Mar 1 2023, 2:30 PM

LGTM. Let me know if you like this to be committed by proxy.

This revision is now accepted and ready to land.Mar 1 2023, 2:30 PM

LGTM. Let me know if you like this to be committed by proxy.

Thanks @snehasish. I don’t have commit access, can you land this patch for me?

This revision was automatically updated to reflect the committed changes.