This is an archive of the discontinued LLVM Phabricator instance.

Differential D144938

[NFC][GVN] Precommit tests for D143129
Needs ReviewPublic

Authored by mnadeem on Feb 27 2023, 7:54 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None

Diff Detail

Event Timeline

mnadeem created this revision.Feb 27 2023, 7:54 PM
mnadeem created this object with visibility "No One".
Herald added a project: Restricted Project. · View Herald TranscriptFeb 27 2023, 7:54 PM
mnadeem requested review of this revision.Feb 27 2023, 7:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 27 2023, 7:54 PM
mnadeem added a child revision: D143129: [GVN] Restrict equality propagation for pointers.Feb 27 2023, 7:58 PM
mnadeem changed the visibility from "No One" to "Public (No Login Required)".Feb 27 2023, 8:04 PM
Herald added a subscriber: llvm-commits. · View Herald TranscriptFeb 27 2023, 8:04 PM
mnadeem updated this revision to Diff 511719.Apr 7 2023, 10:48 AM
Harbormaster completed remote builds in B224235: Diff 511719.Apr 7 2023, 11:25 AM

Revision Contents

PathSize
llvm/
test/
Transforms/
GVN/
213 lines

Diff 511719

llvm/test/Transforms/GVN/condprop.ll

Show First 20 Lines • Show All 506 Lines • ▼ Show 20 Lines
cond_false: cond_false:
br label %ret br label %ret
ret: ret:
%res = phi i32 [ %x, %cond_true ], [ %x, %cond_false ] %res = phi i32 [ %x, %cond_true ], [ %x, %cond_false ]
ret i32 %res ret i32 %res
} }
; On the path from entry->if->end we know that ptr1==ptr2, so we can determine ; Check that we dont propagate pointer equalities when illegal.
; that gep2 does not alias ptr1 on that path (as it would require that
; ptr2==ptr2+2), so we can perform PRE of the load.
define i32 @test13(ptr %ptr1, ptr %ptr2) { define i32 @test13(ptr %ptr1, ptr %ptr2) {
; CHECK-LABEL: @test13( ; CHECK-LABEL: @test13(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
; CHECK-NEXT: [[GEP1:%.*]] = getelementptr i32, ptr [[PTR2:%.*]], i32 1 ; CHECK-NEXT: [[GEP1:%.*]] = getelementptr i32, ptr [[PTR2:%.*]], i32 1
; CHECK-NEXT: [[GEP2:%.*]] = getelementptr i32, ptr [[PTR2]], i32 2 ; CHECK-NEXT: [[GEP2:%.*]] = getelementptr i32, ptr [[PTR2]], i32 2
; CHECK-NEXT: [[CMP:%.*]] = icmp eq ptr [[PTR1:%.*]], [[PTR2]] ; CHECK-NEXT: [[CMP:%.*]] = icmp eq ptr [[PTR1:%.*]], [[PTR2]]
; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[ENTRY_END_CRIT_EDGE:%.*]] ; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[ENTRY_END_CRIT_EDGE:%.*]]
; CHECK: entry.end_crit_edge: ; CHECK: entry.end_crit_edge:
Show All 25 Linesend:
%phi1 = phi ptr [ %ptr1, %if ], [ %gep1, %entry ] %phi1 = phi ptr [ %ptr1, %if ], [ %gep1, %entry ]
%phi2 = phi i32 [ %val1, %if ], [ 0, %entry ] %phi2 = phi i32 [ %val1, %if ], [ 0, %entry ]
store i32 0, ptr %phi1, align 4 store i32 0, ptr %phi1, align 4
%val2 = load i32, ptr %gep2, align 4 %val2 = load i32, ptr %gep2, align 4
%ret = add i32 %phi2, %val2 %ret = add i32 %phi2, %val2
ret i32 %ret ret i32 %ret
} }
define void @test14(ptr %ptr1, ptr noalias %ptr2) { define void @test14(ptr %ptr1, ptr noalias %ptr2, i1 %c1, i1 %c2) {
; CHECK-LABEL: @test14( ; CHECK-LABEL: @test14(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
; CHECK-NEXT: [[GEP1:%.*]] = getelementptr inbounds i32, ptr [[PTR1:%.*]], i32 1 ; CHECK-NEXT: [[GEP1:%.*]] = getelementptr inbounds i32, ptr [[PTR1:%.*]], i32 1
; CHECK-NEXT: [[GEP2:%.*]] = getelementptr inbounds i32, ptr [[PTR1]], i32 2 ; CHECK-NEXT: [[GEP2:%.*]] = getelementptr inbounds i32, ptr [[PTR1]], i32 2
; CHECK-NEXT: br label [[LOOP:%.*]] ; CHECK-NEXT: br label [[LOOP:%.*]]
; CHECK: loop: ; CHECK: loop:
; CHECK-NEXT: br i1 undef, label [[LOOP_IF1_CRIT_EDGE:%.*]], label [[THEN:%.*]] ; CHECK-NEXT: br i1 [[C1:%.*]], label [[LOOP_IF1_CRIT_EDGE:%.*]], label [[THEN:%.*]]
; CHECK: loop.if1_crit_edge: ; CHECK: loop.if1_crit_edge:
; CHECK-NEXT: [[VAL2_PRE:%.*]] = load i32, ptr [[GEP2]], align 4 ; CHECK-NEXT: [[VAL2_PRE:%.*]] = load i32, ptr [[GEP2]], align 4
; CHECK-NEXT: br label [[IF1:%.*]] ; CHECK-NEXT: br label [[IF1:%.*]]
; CHECK: if1: ; CHECK: if1:
; CHECK-NEXT: [[VAL2:%.*]] = phi i32 [ [[VAL2_PRE]], [[LOOP_IF1_CRIT_EDGE]] ], [ [[VAL3:%.*]], [[LOOP_END:%.*]] ] ; CHECK-NEXT: [[VAL2:%.*]] = phi i32 [ [[VAL2_PRE]], [[LOOP_IF1_CRIT_EDGE]] ], [ [[VAL3:%.*]], [[LOOP_END:%.*]] ]
; CHECK-NEXT: store i32 [[VAL2]], ptr [[GEP2]], align 4 ; CHECK-NEXT: store i32 [[VAL2]], ptr [[GEP2]], align 4
; CHECK-NEXT: store i32 0, ptr [[GEP1]], align 4 ; CHECK-NEXT: store i32 0, ptr [[GEP1]], align 4
; CHECK-NEXT: br label [[THEN]] ; CHECK-NEXT: br label [[THEN]]
; CHECK: then: ; CHECK: then:
; CHECK-NEXT: [[CMP:%.*]] = icmp eq ptr [[GEP2]], [[PTR2:%.*]] ; CHECK-NEXT: [[CMP:%.*]] = icmp eq ptr [[GEP2]], [[PTR2:%.*]]
; CHECK-NEXT: br i1 [[CMP]], label [[LOOP_END]], label [[IF2:%.*]] ; CHECK-NEXT: br i1 [[CMP]], label [[LOOP_END]], label [[IF2:%.*]]
; CHECK: if2: ; CHECK: if2:
; CHECK-NEXT: br label [[LOOP_END]] ; CHECK-NEXT: br label [[LOOP_END]]
; CHECK: loop.end: ; CHECK: loop.end:
; CHECK-NEXT: [[PHI3:%.*]] = phi ptr [ [[PTR2]], [[THEN]] ], [ [[PTR1]], [[IF2]] ] ; CHECK-NEXT: [[PHI3:%.*]] = phi ptr [ [[PTR2]], [[THEN]] ], [ [[PTR1]], [[IF2]] ]
; CHECK-NEXT: [[VAL3]] = load i32, ptr [[GEP2]], align 4 ; CHECK-NEXT: [[VAL3]] = load i32, ptr [[GEP2]], align 4
; CHECK-NEXT: store i32 [[VAL3]], ptr [[PHI3]], align 4 ; CHECK-NEXT: store i32 [[VAL3]], ptr [[PHI3]], align 4
; CHECK-NEXT: br i1 undef, label [[LOOP]], label [[IF1]] ; CHECK-NEXT: br i1 [[C2:%.*]], label [[LOOP]], label [[IF1]]
; ;
entry: entry:
%gep1 = getelementptr inbounds i32, ptr %ptr1, i32 1 %gep1 = getelementptr inbounds i32, ptr %ptr1, i32 1
%gep2 = getelementptr inbounds i32, ptr %ptr1, i32 2 %gep2 = getelementptr inbounds i32, ptr %ptr1, i32 2
br label %loop br label %loop
loop: loop:
%phi1 = phi ptr [ %gep3, %loop.end ], [ %gep1, %entry ] %phi1 = phi ptr [ %gep3, %loop.end ], [ %gep1, %entry ]
br i1 undef, label %if1, label %then br i1 %c1, label %if1, label %then
if1: if1:
%val2 = load i32, ptr %gep2, align 4 %val2 = load i32, ptr %gep2, align 4
store i32 %val2, ptr %gep2, align 4 store i32 %val2, ptr %gep2, align 4
store i32 0, ptr %phi1, align 4 store i32 0, ptr %phi1, align 4
br label %then br label %then
then: then:
%cmp = icmp eq ptr %gep2, %ptr2 %cmp = icmp eq ptr %gep2, %ptr2
br i1 %cmp, label %loop.end, label %if2 br i1 %cmp, label %loop.end, label %if2
if2: if2:
br label %loop.end br label %loop.end
loop.end: loop.end:
%phi3 = phi ptr [ %gep2, %then ], [ %ptr1, %if2 ] %phi3 = phi ptr [ %gep2, %then ], [ %ptr1, %if2 ]
%val3 = load i32, ptr %gep2, align 4 %val3 = load i32, ptr %gep2, align 4
store i32 %val3, ptr %phi3, align 4 store i32 %val3, ptr %phi3, align 4
%gep3 = getelementptr inbounds i32, ptr %ptr1, i32 1 %gep3 = getelementptr inbounds i32, ptr %ptr1, i32 1
br i1 undef, label %loop, label %if1 br i1 %c2, label %loop, label %if1
} }
define void @single_phi1(ptr %p1) {
; CHECK-LABEL: @single_phi1(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[P2:%.*]] = load ptr, ptr poison, align 8
; CHECK-NEXT: [[CMP1:%.*]] = icmp eq ptr [[P2]], [[P1:%.*]]
; CHECK-NEXT: br i1 [[CMP1]], label [[BB4:%.*]], label [[BB1:%.*]]
; CHECK: bb1:
; CHECK-NEXT: switch i8 poison, label [[BB2:%.*]] [
; CHECK-NEXT: i8 0, label [[BB1]]
; CHECK-NEXT: i8 1, label [[BB3:%.*]]
; CHECK-NEXT: ]
; CHECK: bb2:
; CHECK-NEXT: unreachable
; CHECK: bb3:
; CHECK-NEXT: br label [[BB4]]
; CHECK: bb4:
; CHECK-NEXT: call void @use_bool(i1 true)
; CHECK-NEXT: call void @use_ptr(ptr [[P1]])
; CHECK-NEXT: ret void
;
entry:
%p2 = load ptr, ptr poison, align 8
%cmp1 = icmp eq ptr %p2, %p1
br i1 %cmp1, label %bb4, label %bb1
bb1:
switch i8 poison, label %bb2 [
i8 0, label %bb1
i8 1, label %bb3
]
bb2:
unreachable
bb3:
br label %bb4
bb4:
%phi1 = phi ptr [ %p2, %entry ], [ poison, %bb3 ]
%cmp2 = icmp eq ptr %phi1, %p1
call void @use_bool(i1 %cmp2)
call void @use_ptr(ptr %phi1)
ret void
}
define void @single_phi2(ptr %p1) {
; CHECK-LABEL: @single_phi2(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[P2:%.*]] = load ptr, ptr poison, align 8
; CHECK-NEXT: [[CMP1:%.*]] = icmp eq ptr [[P2]], [[P1:%.*]]
; CHECK-NEXT: br i1 [[CMP1]], label [[BB4:%.*]], label [[BB1:%.*]]
; CHECK: bb1:
; CHECK-NEXT: switch i8 poison, label [[BB2:%.*]] [
; CHECK-NEXT: i8 0, label [[BB1]]
; CHECK-NEXT: i8 1, label [[BB3:%.*]]
; CHECK-NEXT: ]
; CHECK: bb2:
; CHECK-NEXT: br label [[BB4]]
; CHECK: bb3:
; CHECK-NEXT: br label [[BB4]]
; CHECK: bb4:
; CHECK-NEXT: [[PHI1:%.*]] = phi ptr [ [[P1]], [[ENTRY:%.*]] ], [ [[P2]], [[BB2]] ], [ poison, [[BB3]] ]
; CHECK-NEXT: [[CMP2:%.*]] = icmp eq ptr [[PHI1]], [[P1]]
; CHECK-NEXT: call void @use_bool(i1 [[CMP2]])
; CHECK-NEXT: call void @use_ptr(ptr [[PHI1]])
; CHECK-NEXT: ret void
;
entry:
%p2 = load ptr, ptr poison, align 8
%cmp1 = icmp eq ptr %p2, %p1
br i1 %cmp1, label %bb4, label %bb1
bb1:
switch i8 poison, label %bb2 [
i8 0, label %bb1
i8 1, label %bb3
]
bb2:
br label %bb4
bb3:
br label %bb4
bb4:
%phi1 = phi ptr [ %p2, %entry ], [ %p2, %bb2 ], [ poison, %bb3 ]
%cmp2 = icmp eq ptr %phi1, %p1
call void @use_bool(i1 %cmp2)
call void @use_ptr(ptr %phi1)
ret void
}
define void @multiple_phi1(ptr %p1) {
; CHECK-LABEL: @multiple_phi1(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[P2:%.*]] = load ptr, ptr poison, align 8
; CHECK-NEXT: [[CMP1:%.*]] = icmp eq ptr [[P2]], [[P1:%.*]]
; CHECK-NEXT: br i1 [[CMP1]], label [[BB4:%.*]], label [[BB1:%.*]]
; CHECK: bb1:
; CHECK-NEXT: switch i8 poison, label [[BB2:%.*]] [
; CHECK-NEXT: i8 0, label [[BB1]]
; CHECK-NEXT: i8 1, label [[BB3:%.*]]
; CHECK-NEXT: ]
; CHECK: bb2:
; CHECK-NEXT: unreachable
; CHECK: bb3:
; CHECK-NEXT: br label [[BB4]]
; CHECK: bb4:
; CHECK-NEXT: call void @use_bool(i1 true)
; CHECK-NEXT: br label [[BB5:%.*]]
; CHECK: bb5:
; CHECK-NEXT: call void @use_ptr(ptr [[P1]])
; CHECK-NEXT: br label [[BB5]]
;
entry:
%p2 = load ptr, ptr poison, align 8
%cmp1 = icmp eq ptr %p2, %p1
br i1 %cmp1, label %bb4, label %bb1
bb1:
switch i8 poison, label %bb2 [
i8 0, label %bb1
i8 1, label %bb3
]
bb2:
unreachable
bb3:
br label %bb4
bb4:
%phi1 = phi ptr [ %p2, %entry ], [ poison, %bb3 ]
%cmp2 = icmp eq ptr %phi1, %p1
call void @use_bool(i1 %cmp2)
br label %bb5
bb5:
%phi2 = phi ptr [ poison, %bb5 ], [ %phi1, %bb4 ]
call void @use_ptr(ptr %phi2)
br label %bb5
}
define void @multiple_phi2(ptr %p1) {
; CHECK-LABEL: @multiple_phi2(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[P2:%.*]] = load ptr, ptr poison, align 8
; CHECK-NEXT: [[CMP1:%.*]] = icmp eq ptr [[P2]], [[P1:%.*]]
; CHECK-NEXT: br i1 [[CMP1]], label [[BB4:%.*]], label [[BB1:%.*]]
; CHECK: bb1:
; CHECK-NEXT: switch i8 poison, label [[BB2:%.*]] [
; CHECK-NEXT: i8 0, label [[BB1]]
; CHECK-NEXT: i8 1, label [[BB3:%.*]]
; CHECK-NEXT: ]
; CHECK: bb2:
; CHECK-NEXT: br label [[BB4]]
; CHECK: bb3:
; CHECK-NEXT: br label [[BB4]]
; CHECK: bb4:
; CHECK-NEXT: [[PHI1:%.*]] = phi ptr [ [[P1]], [[ENTRY:%.*]] ], [ [[P2]], [[BB2]] ], [ poison, [[BB3]] ]
; CHECK-NEXT: [[CMP2:%.*]] = icmp eq ptr [[PHI1]], [[P1]]
; CHECK-NEXT: call void @use_bool(i1 [[CMP2]])
; CHECK-NEXT: br label [[BB5:%.*]]
; CHECK: bb5:
; CHECK-NEXT: call void @use_ptr(ptr [[PHI1]])
; CHECK-NEXT: br label [[BB5]]
;
entry:
%p2 = load ptr, ptr poison, align 8
%cmp1 = icmp eq ptr %p2, %p1
br i1 %cmp1, label %bb4, label %bb1
bb1:
switch i8 poison, label %bb2 [
i8 0, label %bb1
i8 1, label %bb3
]
bb2:
br label %bb4
bb3:
br label %bb4
bb4:
%phi1 = phi ptr [ %p2, %entry ], [ %p2, %bb2 ], [ poison, %bb3 ]
%cmp2 = icmp eq ptr %phi1, %p1
call void @use_bool(i1 %cmp2)
br label %bb5
bb5:
%phi2 = phi ptr [ poison, %bb5 ], [ %phi1, %bb4 ]
call void @use_ptr(ptr %phi2)
br label %bb5
}
declare void @use_bool(i1)
declare void @use_ptr(ptr)