This is an archive of the discontinued LLVM Phabricator instance.

[Tooling/Inclusion] Add the generic abs symbol to the table.
ClosedPublic

Authored by hokein on Feb 24 2023, 4:19 AM.

Diff Detail

Event Timeline

hokein created this revision.Feb 24 2023, 4:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2023, 4:19 AM
hokein requested review of this revision.Feb 24 2023, 4:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2023, 4:19 AM

this fixes the abs in the mentioned issue, but leaves the friends out :( those are specifically std::labs, std::llabs, std::imaxabs

this fixes the abs in the mentioned issue, but leaves the friends out :( those are specifically std::labs, std::llabs, std::imaxabs

These symbols are already covered in the generated StdSymbolMap.inc file :)

kadircet accepted this revision.Feb 24 2023, 4:44 AM

oh right, i thought these were also provided by multiple headers, but looks like they're only provided by cstdlib, thanks!

This revision is now accepted and ready to land.Feb 24 2023, 4:44 AM
This revision was landed with ongoing or failed builds.Feb 24 2023, 4:56 AM
This revision was automatically updated to reflect the committed changes.