This is an archive of the discontinued LLVM Phabricator instance.

Differential D144713

[Tooling/Includsion] Add the missing NULL symbol to the table.
ClosedPublic

Authored by hokein on Feb 24 2023, 2:48 AM.

Details

Reviewers
kadircet
Commits
rGc86f05dd48d2: [Tooling/Inclusion] Add the missing NULL symbol to the table.

Diff Detail

Unit TestsFailed

TimeTest
150 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/ranges/range_adaptors/range_all::all.nodiscard.verify.cpp
170 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/ranges/range_adaptors/range_common_view::adaptor.nodiscard.verify.cpp
160 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/ranges/range_adaptors/range_reverse::adaptor.nodiscard.verify.cpp
290 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/ranges/range_adaptors/range_transform::adaptor.nodiscard.verify.cpp
2,680 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.std/algorithms/alg_modifying_operations/alg_copy::ranges.copy.segmented.pass.cpp
View Full Test Results (22 Failed)

Event Timeline

hokein created this revision.Feb 24 2023, 2:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2023, 2:48 AM
hokein requested review of this revision.Feb 24 2023, 2:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2023, 2:48 AM
kadircet added inline comments.Feb 24 2023, 2:52 AM
clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc
242

we use None for global namespace rather than leaving empty. let's keep it that way?

hokein updated this revision to Diff 500126.Feb 24 2023, 3:12 AM

oops, fix the patch

kadircet accepted this revision.Feb 24 2023, 3:30 AM

thanks!

This revision is now accepted and ready to land.Feb 24 2023, 3:30 AM
Harbormaster completed remote builds in B215705: Diff 500126.Feb 24 2023, 3:48 AM
This revision was landed with ongoing or failed builds.Feb 24 2023, 4:00 AM
Closed by commit rGc86f05dd48d2: [Tooling/Inclusion] Add the missing NULL symbol to the table. (authored by hokein). · Explain Why
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
hokein added a commit: rGc86f05dd48d2: [Tooling/Inclusion] Add the missing NULL symbol to the table..

Revision Contents

PathSize
clang/
lib/
Tooling/
Inclusions/
Stdlib/
16 lines

Diff 500126

clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc

Show First 20 Lines • Show All 231 Lines • ▼ Show 20 Lines
SYMBOL(ssize, std::, <unordered_map>) SYMBOL(ssize, std::, <unordered_map>)
SYMBOL(ssize, std::, <unordered_set>) SYMBOL(ssize, std::, <unordered_set>)
SYMBOL(ssize, std::, <vector>) SYMBOL(ssize, std::, <vector>)
// std::get has a few variants for different types (tuple, array, pair etc) // std::get has a few variants for different types (tuple, array, pair etc)
// which is tricky to disambiguate without type information. // which is tricky to disambiguate without type information.
// Don't set any header for it, as it comes with the type header. // Don't set any header for it, as it comes with the type header.
SYMBOL(get, std::, /*no headers*/) SYMBOL(get, std::, /*no headers*/)
// Macros
SYMBOL(NULL, None, <cstddef>)
kadircetUnsubmitted
Done
ReplyInline Actions

we use None for global namespace rather than leaving empty. let's keep it that way?

kadircet: we use `None` for global namespace rather than leaving empty. let's keep it that way?
SYMBOL(NULL, None, <stddef.h>)
SYMBOL(NULL, None, <cstdlib>)
SYMBOL(NULL, None, <stdlib.h>)
SYMBOL(NULL, None, <cstring>)
SYMBOL(NULL, None, <string.h>)
SYMBOL(NULL, None, <cwchar>)
SYMBOL(NULL, None, <wchar.h>)
SYMBOL(NULL, None, <ctime>)
SYMBOL(NULL, None, <time.h>)
SYMBOL(NULL, None, <clocale>)
SYMBOL(NULL, None, <locale.h>)
SYMBOL(NULL, None, <cstdio>)
SYMBOL(NULL, None, <stdio.h>)