This is an archive of the discontinued LLVM Phabricator instance.

Differential D144669

[HWASAN][LSAN] Only initialize Symbolizer if leak checking is enabled
ClosedPublic

Authored by kstoimenov on Feb 23 2023, 12:32 PM.

Details

Reviewers
hctim
Commits
rG7b7db789ff3d: [HWASAN][LSAN] Only initialize Symbolizer if leak checking is enabled

Diff Detail

Event Timeline

kstoimenov created this revision.Feb 23 2023, 12:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2023, 12:32 PM
Herald added a subscriber: Enna1. · View Herald Transcript
kstoimenov requested review of this revision.Feb 23 2023, 12:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2023, 12:32 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kstoimenov added a reviewer: hctim.Feb 23 2023, 12:33 PM
Harbormaster completed remote builds in B215586: Diff 499952.Feb 23 2023, 1:27 PM
hctim accepted this revision.Feb 23 2023, 1:37 PM
This revision is now accepted and ready to land.Feb 23 2023, 1:37 PM
Closed by commit rG7b7db789ff3d: [HWASAN][LSAN] Only initialize Symbolizer if leak checking is enabled (authored by kstoimenov). · Explain WhyFeb 23 2023, 1:39 PM
This revision was automatically updated to reflect the committed changes.
kstoimenov added a commit: rG7b7db789ff3d: [HWASAN][LSAN] Only initialize Symbolizer if leak checking is enabled.

Revision Contents

PathSize
compiler-rt/
lib/
hwasan/
4 lines

Diff 499952

compiler-rt/lib/hwasan/hwasan.cpp

Show First 20 Lines • Show All 394 Lines • ▼ Show 20 Lines if (CAN_SANITIZE_LEAKS) {
__lsan::InitCommonLsan(); __lsan::InitCommonLsan();
InstallAtExitCheckLeaks(); InstallAtExitCheckLeaks();
} }
#if HWASAN_CONTAINS_UBSAN #if HWASAN_CONTAINS_UBSAN
__ubsan::InitAsPlugin(); __ubsan::InitAsPlugin();
#endif #endif
if (CAN_SANITIZE_LEAKS) { if (CAN_SANITIZE_LEAKS && common_flags()->detect_leaks) {
__lsan::ScopedInterceptorDisabler disabler; __lsan::ScopedInterceptorDisabler disabler;
Symbolizer::LateInitialize(); Symbolizer::LateInitialize();
} else {
Symbolizer::LateInitialize();
} }
VPrintf(1, "HWAddressSanitizer init done\n"); VPrintf(1, "HWAddressSanitizer init done\n");
hwasan_init_is_running = 0; hwasan_init_is_running = 0;
hwasan_inited = 1; hwasan_inited = 1;
} }
▲ Show 20 Lines • Show All 232 Lines • Show Last 20 Lines