This is an archive of the discontinued LLVM Phabricator instance.

Differential D144435

[libc][CMake] Missing TableGen include
ClosedPublic

Authored by phosek on Feb 20 2023, 3:08 PM.

Details

Reviewers
sivachandra
Commits
rG1d7dad8ae0d2: [libc][CMake] Missing TableGen include
Summary

HdrGen CMake build uses TableGen so it should include TableGen module.

Diff Detail

Event Timeline

phosek created this revision.Feb 20 2023, 3:08 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 20 2023, 3:08 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
phosek requested review of this revision.Feb 20 2023, 3:08 PM
Harbormaster completed remote builds in B214864: Diff 498970.Feb 20 2023, 3:17 PM
sivachandra accepted this revision.Feb 21 2023, 9:01 AM
This revision is now accepted and ready to land.Feb 21 2023, 9:01 AM
Closed by commit rG1d7dad8ae0d2: [libc][CMake] Missing TableGen include (authored by phosek). · Explain WhyFeb 21 2023, 11:58 AM
This revision was automatically updated to reflect the committed changes.
phosek added a commit: rG1d7dad8ae0d2: [libc][CMake] Missing TableGen include.

Revision Contents

PathSize
libc/
utils/
HdrGen/
2 lines

Diff 499263

libc/utils/HdrGen/CMakeLists.txt

include(TableGen)
set(LLVM_LINK_COMPONENTS Support) set(LLVM_LINK_COMPONENTS Support)
add_tablegen(libc-hdrgen LIBC add_tablegen(libc-hdrgen LIBC
Command.h Command.h
Command.cpp Command.cpp
Generator.cpp Generator.cpp
Generator.h Generator.h
IncludeFileCommand.cpp IncludeFileCommand.cpp
Show All 10 Lines