This is an archive of the discontinued LLVM Phabricator instance.

Differential D144357

[libc] Add Month enum, refactor mktime_test
ClosedPublic

Authored by jeffbailey on Feb 19 2023, 7:59 PM.

Details

Reviewers
rtenneti
Commits
rG9ad0ac8eb3d0: [libc] Add Month enum, refactor mktime_test
Summary

Introduce Month enum.

Use designated initializers instead of comments to ensure that tm_data
is initialized correctly. Use Month enum for initializing .tm_mon to
avoid off-by-one errors.

Co-authored-by: Raman Tenneti <rtenneti@google.com>

Diff Detail

Event Timeline

jeffbailey created this revision.Feb 19 2023, 7:59 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 19 2023, 7:59 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
jeffbailey requested review of this revision.Feb 19 2023, 7:59 PM
Harbormaster completed remote builds in B214662: Diff 498712.Feb 19 2023, 8:07 PM
rtenneti accepted this revision.Feb 21 2023, 9:18 AM

Changes LGTM. Thanks much Jeff for the CL.

This revision is now accepted and ready to land.Feb 21 2023, 9:18 AM
Closed by commit rG9ad0ac8eb3d0: [libc] Add Month enum, refactor mktime_test (authored by jeffbailey). · Explain WhyFeb 21 2023, 9:24 AM
This revision was automatically updated to reflect the committed changes.
jeffbailey added a commit: rG9ad0ac8eb3d0: [libc] Add Month enum, refactor mktime_test.

Revision Contents

PathSize
libc/
src/
time/
16 lines
test/
src/
time/
729 lines

Diff 499210

libc/src/time/time_utils.h

Show All 16 Lines
#include "src/errno/llvmlibc_errno.h" #include "src/errno/llvmlibc_errno.h"
#include "src/time/mktime.h" #include "src/time/mktime.h"
#include <stdint.h> #include <stdint.h>
namespace __llvm_libc { namespace __llvm_libc {
namespace time_utils { namespace time_utils {
enum Month : int {
JANUARY,
FEBRUARY,
MARCH,
APRIL,
MAY,
JUNE,
JULY,
AUGUST,
SEPTEMBER,
OCTOBER,
NOVEMBER,
DECEMBER
};
struct TimeConstants { struct TimeConstants {
static constexpr int SECONDS_PER_MIN = 60; static constexpr int SECONDS_PER_MIN = 60;
static constexpr int SECONDS_PER_HOUR = 3600; static constexpr int SECONDS_PER_HOUR = 3600;
static constexpr int SECONDS_PER_DAY = 86400; static constexpr int SECONDS_PER_DAY = 86400;
static constexpr int MINUTES_PER_HOUR = 60;
static constexpr int DAYS_PER_WEEK = 7; static constexpr int DAYS_PER_WEEK = 7;
static constexpr int MONTHS_PER_YEAR = 12; static constexpr int MONTHS_PER_YEAR = 12;
static constexpr int DAYS_PER_NON_LEAP_YEAR = 365; static constexpr int DAYS_PER_NON_LEAP_YEAR = 365;
static constexpr int DAYS_PER_LEAP_YEAR = 366; static constexpr int DAYS_PER_LEAP_YEAR = 366;
static constexpr int TIME_YEAR_BASE = 1900; static constexpr int TIME_YEAR_BASE = 1900;
static constexpr int EPOCH_YEAR = 1970; static constexpr int EPOCH_YEAR = 1970;
static constexpr int EPOCH_WEEK_DAY = 4; static constexpr int EPOCH_WEEK_DAY = 4;
static constexpr int NUMBER_OF_SECONDS_IN_LEAP_YEAR = static constexpr int NUMBER_OF_SECONDS_IN_LEAP_YEAR =
▲ Show 20 Lines • Show All 95 Lines • Show Last 20 Lines

libc/test/src/time/mktime_test.cpp

Show All 12 Lines
#include "test/src/time/TmHelper.h" #include "test/src/time/TmHelper.h"
#include "test/src/time/TmMatcher.h" #include "test/src/time/TmMatcher.h"
#include <errno.h> #include <errno.h>
#include <limits.h> #include <limits.h>
using __llvm_libc::testing::ErrnoSetterMatcher::Fails; using __llvm_libc::testing::ErrnoSetterMatcher::Fails;
using __llvm_libc::testing::ErrnoSetterMatcher::Succeeds; using __llvm_libc::testing::ErrnoSetterMatcher::Succeeds;
using __llvm_libc::time_utils::TimeConstants; using __llvm_libc::time_utils::Month;
static inline time_t call_mktime(struct tm *tm_data, int year, int month, static inline constexpr int tm_year(int year) {
int mday, int hour, int min, int sec, int wday, return year - TimeConstants::TIME_YEAR_BASE;
int yday) {
__llvm_libc::tmhelper::testing::initialize_tm_data(
tm_data, year, month, mday, hour, min, sec, wday, yday);
return __llvm_libc::mktime(tm_data);
} }
TEST(LlvmLibcMkTime, FailureSetsErrno) { TEST(LlvmLibcMkTime, FailureSetsErrno) {
struct tm tm_data; struct tm tm_data {
__llvm_libc::tmhelper::testing::initialize_tm_data( .tm_sec = INT_MAX, .tm_min = INT_MAX, .tm_hour = INT_MAX,
&tm_data, INT_MAX, INT_MAX, INT_MAX, INT_MAX, INT_MAX, -1, 0, 0); .tm_mday = INT_MAX, .tm_mon = INT_MAX - 1, .tm_year = tm_year(INT_MAX),
.tm_wday = 0, .tm_yday = 0
};
EXPECT_THAT(__llvm_libc::mktime(&tm_data), Fails(EOVERFLOW)); EXPECT_THAT(__llvm_libc::mktime(&tm_data), Fails(EOVERFLOW));
} }
TEST(LlvmLibcMkTime, InvalidSeconds) { TEST(LlvmLibcMkTime, InvalidSeconds) {
struct tm tm_data; {
// -1 second from 1970-01-01 00:00:00 returns 1969-12-31 23:59:59. // -1 second from 1970-01-01 00:00:00 returns 1969-12-31 23:59:59.
EXPECT_THAT(call_mktime(&tm_data, struct tm tm_data {
1970, // year .tm_sec = -1, .tm_min = 0, .tm_hour = 0, .tm_mday = 1,
1, // month .tm_mon = Month::JANUARY, .tm_year = tm_year(1970), .tm_wday = 0,
1, // day .tm_yday = 0
0, // hr };
0, // min EXPECT_THAT(__llvm_libc::mktime(&tm_data), Succeeds(-1));
-1, // sec EXPECT_TM_EQ((tm{.tm_sec = 59,
0, // wday .tm_min = 59,
0), // yday .tm_hour = 23,
Succeeds(-1)); .tm_mday = 31,
EXPECT_TM_EQ((tm{59, // sec .tm_mon = Month::DECEMBER,
59, // min .tm_year = tm_year(1969),
23, // hr .tm_wday = 3,
31, // day .tm_yday = 364}),
12 - 1, // tm_mon starts with 0 for Jan
1969 - TimeConstants::TIME_YEAR_BASE, // year
3, // wday
364, // yday
0}),
tm_data); tm_data);
}
{
// 60 seconds from 1970-01-01 00:00:00 returns 1970-01-01 00:01:00. // 60 seconds from 1970-01-01 00:00:00 returns 1970-01-01 00:01:00.
EXPECT_THAT(call_mktime(&tm_data, struct tm tm_data {
1970, // year .tm_sec = 60, .tm_min = 0, .tm_hour = 0, .tm_mday = 1,
1, // month .tm_mon = Month::JANUARY, .tm_year = tm_year(1970), .tm_wday = 0,
1, // day .tm_yday = 0
0, // hr };
0, // min EXPECT_THAT(__llvm_libc::mktime(&tm_data), Succeeds(60));
60, // sec EXPECT_TM_EQ((tm{.tm_sec = 0,
0, // wday .tm_min = 1,
0), // yday .tm_hour = 0,
Succeeds(60)); .tm_mday = 1,
EXPECT_TM_EQ((tm{0, // sec .tm_mon = Month::JANUARY,
1, // min .tm_year = tm_year(1970),
0, // hr .tm_wday = 4,
1, // day .tm_yday = 0}),
0, // tm_mon starts with 0 for Jan
1970 - TimeConstants::TIME_YEAR_BASE, // year
4, // wday
0, // yday
0}),
tm_data); tm_data);
} }
}
TEST(LlvmLibcMkTime, InvalidMinutes) { TEST(LlvmLibcMkTime, InvalidMinutes) {
struct tm tm_data; {
// -1 minute from 1970-01-01 00:00:00 returns 1969-12-31 23:59:00. // -1 minute from 1970-01-01 00:00:00 returns 1969-12-31 23:59:00.
EXPECT_THAT(call_mktime(&tm_data, struct tm tm_data {
1970, // year .tm_sec = 0, .tm_min = -1, .tm_hour = 0, .tm_mday = 1,
1, // month .tm_mon = Month::JANUARY, .tm_year = tm_year(1970), .tm_wday = 0,
1, // day .tm_yday = 0
0, // hr };
-1, // min EXPECT_THAT(__llvm_libc::mktime(&tm_data),
0, // sec
0, // wday
0), // yday
Succeeds(-TimeConstants::SECONDS_PER_MIN)); Succeeds(-TimeConstants::SECONDS_PER_MIN));
EXPECT_TM_EQ((tm{0, // sec EXPECT_TM_EQ((tm{.tm_sec = 0,
59, // min .tm_min = 59,
23, // hr .tm_hour = 23,
31, // day .tm_mday = 31,
11, // tm_mon starts with 0 for Jan .tm_mon = Month::DECEMBER,
1969 - TimeConstants::TIME_YEAR_BASE, // year .tm_year = tm_year(1969),
3, // wday .tm_wday = 3,
0, // yday .tm_yday = 0}),
0}),
tm_data); tm_data);
}
{
// 60 minutes from 1970-01-01 00:00:00 returns 1970-01-01 01:00:00. // 60 minutes from 1970-01-01 00:00:00 returns 1970-01-01 01:00:00.
EXPECT_THAT(call_mktime(&tm_data, struct tm tm_data {
1970, // year .tm_sec = 0, .tm_min = 60, .tm_hour = 0, .tm_mday = 1,
1, // month .tm_mon = Month::JANUARY, .tm_year = tm_year(1970), .tm_wday = 0,
1, // day .tm_yday = 0
0, // hr };
60, // min EXPECT_THAT(__llvm_libc::mktime(&tm_data),
0, // sec
0, // wday
0), // yday
Succeeds(60 * TimeConstants::SECONDS_PER_MIN)); Succeeds(60 * TimeConstants::SECONDS_PER_MIN));
EXPECT_TM_EQ((tm{0, // sec EXPECT_TM_EQ((tm{.tm_sec = 0,
0, // min .tm_min = 0,
1, // hr .tm_hour = 1,
1, // day .tm_mday = 1,
0, // tm_mon starts with 0 for Jan .tm_mon = Month::JANUARY,
1970 - TimeConstants::TIME_YEAR_BASE, // year .tm_year = tm_year(1970),
4, // wday .tm_wday = 4,
0, // yday .tm_yday = 0}),
0}),
tm_data); tm_data);
} }
}
TEST(LlvmLibcMkTime, InvalidHours) { TEST(LlvmLibcMkTime, InvalidHours) {
struct tm tm_data; {
// -1 hour from 1970-01-01 00:00:00 returns 1969-12-31 23:00:00. // -1 hour from 1970-01-01 00:00:00 returns 1969-12-31 23:00:00.
EXPECT_THAT(call_mktime(&tm_data, struct tm tm_data {
1970, // year .tm_sec = 0, .tm_min = 0, .tm_hour = -1, .tm_mday = 1,
1, // month .tm_mon = Month::JANUARY, .tm_year = tm_year(1970), .tm_wday = 0,
1, // day .tm_yday = 0
-1, // hr };
0, // min EXPECT_THAT(__llvm_libc::mktime(&tm_data),
0, // sec
0, // wday
0), // yday
Succeeds(-TimeConstants::SECONDS_PER_HOUR)); Succeeds(-TimeConstants::SECONDS_PER_HOUR));
EXPECT_TM_EQ((tm{0, // sec EXPECT_TM_EQ((tm{.tm_sec = 0,
0, // min .tm_min = 0,
23, // hr .tm_hour = 23,
31, // day .tm_mday = 31,
11, // tm_mon starts with 0 for Jan .tm_mon = Month::DECEMBER,
1969 - TimeConstants::TIME_YEAR_BASE, // year .tm_year = tm_year(1969),
3, // wday .tm_wday = 3,
0, // yday .tm_yday = 0}),
0}),
tm_data); tm_data);
}
{
// 24 hours from 1970-01-01 00:00:00 returns 1970-01-02 00:00:00. // 24 hours from 1970-01-01 00:00:00 returns 1970-01-02 00:00:00.
EXPECT_THAT(call_mktime(&tm_data, struct tm tm_data {
1970, // year .tm_sec = 0, .tm_min = 0, .tm_hour = 24, .tm_mday = 1,
1, // month .tm_mon = Month::JANUARY, .tm_year = tm_year(1970), .tm_wday = 0,
1, // day .tm_yday = 0
24, // hr };
0, // min EXPECT_THAT(__llvm_libc::mktime(&tm_data),
0, // sec
0, // wday
0), // yday
Succeeds(24 * TimeConstants::SECONDS_PER_HOUR)); Succeeds(24 * TimeConstants::SECONDS_PER_HOUR));
EXPECT_TM_EQ((tm{0, // sec EXPECT_TM_EQ((tm{.tm_sec = 0,
0, // min .tm_min = 0,
0, // hr .tm_hour = 0,
2, // day .tm_mday = 2,
0, // tm_mon starts with 0 for Jan .tm_mon = Month::JANUARY,
1970 - TimeConstants::TIME_YEAR_BASE, // year .tm_year = tm_year(1970),
5, // wday .tm_wday = 5,
0, // yday .tm_yday = 0}),
0}),
tm_data); tm_data);
} }
}
TEST(LlvmLibcMkTime, InvalidYear) { TEST(LlvmLibcMkTime, InvalidYear) {
struct tm tm_data;
// -1 year from 1970-01-01 00:00:00 returns 1969-01-01 00:00:00. // -1 year from 1970-01-01 00:00:00 returns 1969-01-01 00:00:00.
EXPECT_THAT(call_mktime(&tm_data, struct tm tm_data {
1969, // year .tm_sec = 0, .tm_min = 0, .tm_hour = 0, .tm_mday = 1,
1, // month .tm_mon = Month::JANUARY, .tm_year = tm_year(1969), .tm_wday = 0,
1, // day .tm_yday = 0
0, // hr };
0, // min EXPECT_THAT(__llvm_libc::mktime(&tm_data),
0, // sec
0, // wday
0), // yday
Succeeds(-TimeConstants::DAYS_PER_NON_LEAP_YEAR * Succeeds(-TimeConstants::DAYS_PER_NON_LEAP_YEAR *
TimeConstants::SECONDS_PER_DAY)); TimeConstants::SECONDS_PER_DAY));
EXPECT_TM_EQ((tm{0, // sec EXPECT_TM_EQ((tm{.tm_sec = 0,
0, // min .tm_min = 0,
0, // hr .tm_hour = 0,
1, // day .tm_mday = 1,
0, // tm_mon starts with 0 for Jan .tm_mon = Month::JANUARY,
1969 - TimeConstants::TIME_YEAR_BASE, // year .tm_year = tm_year(1969),
3, // wday .tm_wday = 3,
0, // yday .tm_yday = 0}),
0}),
tm_data); tm_data);
} }
TEST(LlvmLibcMkTime, InvalidEndOf32BitEpochYear) { TEST(LlvmLibcMkTime, InvalidEndOf32BitEpochYear) {
if (sizeof(size_t) != 4) if (sizeof(size_t) != 4)
return; return;
struct tm tm_data; {
// 2038-01-19 03:14:08 tests overflow of the second in 2038. // 2038-01-19 03:14:08 tests overflow of the second in 2038.
EXPECT_THAT(call_mktime(&tm_data, 2038, 1, 19, 3, 14, 8, 0, 0), struct tm tm_data {
.tm_sec = 8, .tm_min = 14, .tm_hour = 3, .tm_mday = 19,
.tm_mon = Month::JANUARY, .tm_year = tm_year(2038), .tm_wday = 0,
.tm_yday = 0
};
EXPECT_THAT(__llvm_libc::mktime(&tm_data),
Succeeds(TimeConstants::OUT_OF_RANGE_RETURN_VALUE)); Succeeds(TimeConstants::OUT_OF_RANGE_RETURN_VALUE));
}
{
// 2038-01-19 03:15:07 tests overflow of the minute in 2038. // 2038-01-19 03:15:07 tests overflow of the minute in 2038.
EXPECT_THAT(call_mktime(&tm_data, 2038, 1, 19, 3, 15, 7, 0, 0), struct tm tm_data {
.tm_sec = 7, .tm_min = 15, .tm_hour = 3, .tm_mday = 19,
.tm_mon = Month::JANUARY, .tm_year = tm_year(2038), .tm_wday = 0,
.tm_yday = 0
};
EXPECT_THAT(__llvm_libc::mktime(&tm_data),
Succeeds(TimeConstants::OUT_OF_RANGE_RETURN_VALUE)); Succeeds(TimeConstants::OUT_OF_RANGE_RETURN_VALUE));
}
{
// 2038-01-19 04:14:07 tests overflow of the hour in 2038. // 2038-01-19 04:14:07 tests overflow of the hour in 2038.
EXPECT_THAT(call_mktime(&tm_data, 2038, 1, 19, 4, 14, 7, 0, 0), struct tm tm_data {
.tm_sec = 7, .tm_min = 14, .tm_hour = 4, .tm_mday = 19,
.tm_mon = Month::JANUARY, .tm_year = tm_year(2038), .tm_wday = 0,
.tm_yday = 0
};
EXPECT_THAT(__llvm_libc::mktime(&tm_data),
Succeeds(TimeConstants::OUT_OF_RANGE_RETURN_VALUE)); Succeeds(TimeConstants::OUT_OF_RANGE_RETURN_VALUE));
}
{
// 2038-01-20 03:14:07 tests overflow of the day in 2038. // 2038-01-20 03:14:07 tests overflow of the day in 2038.
EXPECT_THAT(call_mktime(&tm_data, 2038, 1, 20, 3, 14, 7, 0, 0), struct tm tm_data {
.tm_sec = 7, .tm_min = 14, .tm_hour = 3, .tm_mday = 20,
.tm_mon = Month::JANUARY, .tm_year = tm_year(2038), .tm_wday = 0,
.tm_yday = 0
};
EXPECT_THAT(__llvm_libc::mktime(&tm_data),
Succeeds(TimeConstants::OUT_OF_RANGE_RETURN_VALUE)); Succeeds(TimeConstants::OUT_OF_RANGE_RETURN_VALUE));
}
{
// 2038-02-19 03:14:07 tests overflow of the month in 2038. // 2038-02-19 03:14:07 tests overflow of the month in 2038.
EXPECT_THAT(call_mktime(&tm_data, 2038, 2, 19, 3, 14, 7, 0, 0), struct tm tm_data {
.tm_sec = 7, .tm_min = 14, .tm_hour = 3, .tm_mday = 19,
.tm_mon = Month::FEBRUARY, .tm_year = tm_year(2038), .tm_wday = 0,
.tm_yday = 0
};
EXPECT_THAT(__llvm_libc::mktime(&tm_data),
Succeeds(TimeConstants::OUT_OF_RANGE_RETURN_VALUE)); Succeeds(TimeConstants::OUT_OF_RANGE_RETURN_VALUE));
}
{
// 2039-01-19 03:14:07 tests overflow of the year. // 2039-01-19 03:14:07 tests overflow of the year.
EXPECT_THAT(call_mktime(&tm_data, 2039, 1, 19, 3, 14, 7, 0, 0), struct tm tm_data {
.tm_sec = 7, .tm_min = 14, .tm_hour = 3, .tm_mday = 19,
.tm_mon = Month::JANUARY, .tm_year = tm_year(2039), .tm_wday = 0,
.tm_yday = 0
};
EXPECT_THAT(__llvm_libc::mktime(&tm_data),
Succeeds(TimeConstants::OUT_OF_RANGE_RETURN_VALUE)); Succeeds(TimeConstants::OUT_OF_RANGE_RETURN_VALUE));
} }
}
TEST(LlvmLibcMkTime, InvalidMonths) { TEST(LlvmLibcMkTime, InvalidMonths) {
struct tm tm_data; {
// -1 month from 1970-01-01 00:00:00 returns 1969-12-01 00:00:00. // -1 month from 1970-01-01 00:00:00 returns 1969-12-01 00:00:00.
EXPECT_THAT(call_mktime(&tm_data, struct tm tm_data {
1970, // year .tm_sec = 0, .tm_min = 0, .tm_hour = 0, .tm_mday = 0, .tm_mon = -1,
0, // month .tm_year = tm_year(1970), .tm_wday = 0, .tm_yday = 0
1, // day };
0, // hr EXPECT_THAT(__llvm_libc::mktime(&tm_data),
0, // min Succeeds(-32 * TimeConstants::SECONDS_PER_DAY));
0, // sec EXPECT_TM_EQ((tm{.tm_sec = 0,
0, // wday .tm_min = 0,
0), // yday .tm_hour = 0,
Succeeds(-31 * TimeConstants::SECONDS_PER_DAY)); .tm_mday = 1,
EXPECT_TM_EQ((tm{0, // sec .tm_mon = Month::DECEMBER,
0, // min .tm_year = tm_year(1969),
0, // hr .tm_wday = 1,
1, // day .tm_yday = 0}),
12 - 1, // tm_mon starts with 0 for Jan
1969 - TimeConstants::TIME_YEAR_BASE, // year
1, // wday
0, // yday
0}),
tm_data); tm_data);
}
{
// 1970-13-01 00:00:00 returns 1971-01-01 00:00:00. // 1970-13-01 00:00:00 returns 1971-01-01 00:00:00.
EXPECT_THAT(call_mktime(&tm_data, struct tm tm_data {
1970, // year .tm_sec = 0, .tm_min = 0, .tm_hour = 0, .tm_mday = 1, .tm_mon = 12,
13, // month .tm_year = tm_year(1970), .tm_wday = 0, .tm_yday = 0
1, // day };
0, // hr EXPECT_THAT(__llvm_libc::mktime(&tm_data),
0, // min
0, // sec
0, // wday
0), // yday
Succeeds(TimeConstants::DAYS_PER_NON_LEAP_YEAR * Succeeds(TimeConstants::DAYS_PER_NON_LEAP_YEAR *
TimeConstants::SECONDS_PER_DAY)); TimeConstants::SECONDS_PER_DAY));
EXPECT_TM_EQ((tm{0, // sec EXPECT_TM_EQ((tm{.tm_sec = 0,
0, // min .tm_min = 0,
0, // hr .tm_hour = 0,
1, // day .tm_mday = 1,
0, // tm_mon starts with 0 for Jan .tm_mon = Month::JANUARY,
1971 - TimeConstants::TIME_YEAR_BASE, // year .tm_year = tm_year(1971),
5, // wday .tm_wday = 5,
0, // yday .tm_yday = 0}),
0}),
tm_data); tm_data);
} }
}
TEST(LlvmLibcMkTime, InvalidDays) { TEST(LlvmLibcMkTime, InvalidDays) {
struct tm tm_data; {
// -1 day from 1970-01-01 00:00:00 returns 1969-12-31 00:00:00. // -1 day from 1970-01-01 00:00:00 returns 1969-12-31 00:00:00.
EXPECT_THAT(call_mktime(&tm_data, struct tm tm_data {
1970, // year .tm_sec = 0, .tm_min = 0, .tm_hour = 0, .tm_mday = (1 - 1),
1, // month .tm_mon = Month::JANUARY, .tm_year = tm_year(1970), .tm_wday = 0,
0, // day .tm_yday = 0
0, // hr };
0, // min EXPECT_THAT(__llvm_libc::mktime(&tm_data),
0, // sec
0, // wday
0), // yday
Succeeds(-1 * TimeConstants::SECONDS_PER_DAY)); Succeeds(-1 * TimeConstants::SECONDS_PER_DAY));
EXPECT_TM_EQ((tm{0, // sec EXPECT_TM_EQ((tm{.tm_sec = 0,
0, // min .tm_min = 0,
0, // hr .tm_hour = 0,
31, // day .tm_mday = 31,
11, // tm_mon starts with 0 for Jan .tm_mon = Month::DECEMBER,
1969 - TimeConstants::TIME_YEAR_BASE, // year .tm_year = tm_year(1969),
3, // wday .tm_wday = 3,
0, // yday .tm_yday = 0}),
0}),
tm_data); tm_data);
}
{
// 1970-01-32 00:00:00 returns 1970-02-01 00:00:00. // 1970-01-32 00:00:00 returns 1970-02-01 00:00:00.
EXPECT_THAT(call_mktime(&tm_data, struct tm tm_data {
1970, // year .tm_sec = 0, .tm_min = 0, .tm_hour = 0, .tm_mday = 32,
1, // month .tm_mon = Month::JANUARY, .tm_year = tm_year(1970), .tm_wday = 0,
32, // day .tm_yday = 0
0, // hr };
0, // min EXPECT_THAT(__llvm_libc::mktime(&tm_data),
0, // sec
0, // wday
0), // yday
Succeeds(31 * TimeConstants::SECONDS_PER_DAY)); Succeeds(31 * TimeConstants::SECONDS_PER_DAY));
EXPECT_TM_EQ((tm{0, // sec EXPECT_TM_EQ((tm{.tm_sec = 0,
0, // min .tm_min = 0,
0, // hr .tm_hour = 0,
1, // day .tm_mday = 1,
0, // tm_mon starts with 0 for Jan .tm_mon = Month::FEBRUARY,
1970 - TimeConstants::TIME_YEAR_BASE, // year .tm_year = tm_year(1970),
0, // wday .tm_wday = 0,
0, // yday .tm_yday = 0}),
0}),
tm_data); tm_data);
}
{
// 1970-02-29 00:00:00 returns 1970-03-01 00:00:00. // 1970-02-29 00:00:00 returns 1970-03-01 00:00:00.
EXPECT_THAT(call_mktime(&tm_data, struct tm tm_data {
1970, // year .tm_sec = 0, .tm_min = 0, .tm_hour = 0, .tm_mday = 29,
2, // month .tm_mon = Month::FEBRUARY, .tm_year = tm_year(1970), .tm_wday = 0,
29, // day .tm_yday = 0
0, // hr };
0, // min EXPECT_THAT(__llvm_libc::mktime(&tm_data),
0, // sec
0, // wday
0), // yday
Succeeds(59 * TimeConstants::SECONDS_PER_DAY)); Succeeds(59 * TimeConstants::SECONDS_PER_DAY));
EXPECT_TM_EQ((tm{0, // sec EXPECT_TM_EQ((tm{.tm_sec = 0,
0, // min .tm_min = 0,
0, // hr .tm_hour = 0,
1, // day .tm_mday = 1,
2, // tm_mon starts with 0 for Jan .tm_mon = Month::MARCH,
1970 - TimeConstants::TIME_YEAR_BASE, // year .tm_year = tm_year(1970),
0, // wday .tm_wday = 0,
0, // yday .tm_yday = 0}),
0}),
tm_data); tm_data);
}
{
// 1972-02-30 00:00:00 returns 1972-03-01 00:00:00. // 1972-02-30 00:00:00 returns 1972-03-01 00:00:00.
EXPECT_THAT(call_mktime(&tm_data, struct tm tm_data {
1972, // year .tm_sec = 0, .tm_min = 0, .tm_hour = 0, .tm_mday = 30,
2, // month .tm_mon = Month::FEBRUARY, .tm_year = tm_year(1972), .tm_wday = 0,
30, // day .tm_yday = 0
0, // hr };
0, // min EXPECT_THAT(__llvm_libc::mktime(&tm_data),
0, // sec
0, // wday
0), // yday
Succeeds(((2 * TimeConstants::DAYS_PER_NON_LEAP_YEAR) + 60) * Succeeds(((2 * TimeConstants::DAYS_PER_NON_LEAP_YEAR) + 60) *
TimeConstants::SECONDS_PER_DAY)); TimeConstants::SECONDS_PER_DAY));
EXPECT_TM_EQ((tm{0, // sec EXPECT_TM_EQ((tm{.tm_sec = 0,
0, // min .tm_min = 0,
0, // hr .tm_hour = 0,
1, // day .tm_mday = 1,
2, // tm_mon starts with 0 for Jan .tm_mon = Month::MARCH,
1972 - TimeConstants::TIME_YEAR_BASE, // year .tm_year = tm_year(1972),
3, // wday .tm_wday = 3,
0, // yday .tm_yday = 0}),
0}),
tm_data); tm_data);
} }
}
TEST(LlvmLibcMkTime, EndOf32BitEpochYear) { TEST(LlvmLibcMkTime, EndOf32BitEpochYear) {
struct tm tm_data;
// Test for maximum value of a signed 32-bit integer. // Test for maximum value of a signed 32-bit integer.
// Test implementation can encode time for Tue 19 January 2038 03:14:07 UTC. // Test implementation can encode time for Tue 19 January 2038 03:14:07 UTC.
EXPECT_THAT(call_mktime(&tm_data, struct tm tm_data {
2038, // year .tm_sec = 7, .tm_min = 14, .tm_hour = 3, .tm_mday = 19,
1, // month .tm_mon = Month::JANUARY, .tm_year = tm_year(2038), .tm_wday = 0,
19, // day .tm_yday = 0
3, // hr };
14, // min EXPECT_THAT(__llvm_libc::mktime(&tm_data), Succeeds(0x7FFFFFFF));
7, // sec EXPECT_TM_EQ((tm{.tm_sec = 7,
0, // wday .tm_min = 14,
0), // yday .tm_hour = 3,
Succeeds(0x7FFFFFFF)); .tm_mday = 19,
EXPECT_TM_EQ((tm{7, // sec .tm_mon = Month::JANUARY,
14, // min .tm_year = tm_year(2038),
3, // hr .tm_wday = 2,
19, // day .tm_yday = 7}),
0, // tm_mon starts with 0 for Jan
2038 - TimeConstants::TIME_YEAR_BASE, // year
2, // wday
7, // yday
0}),
tm_data); tm_data);
} }
TEST(LlvmLibcMkTime, Max64BitYear) { TEST(LlvmLibcMkTime, Max64BitYear) {
if (sizeof(time_t) == 4) if (sizeof(time_t) == 4)
return; return;
{
// Mon Jan 1 12:50:50 2170 (200 years from 1970), // Mon Jan 1 12:50:50 2170 (200 years from 1970),
struct tm tm_data; struct tm tm_data {
EXPECT_THAT(call_mktime(&tm_data, .tm_sec = 50, .tm_min = 50, .tm_hour = 12, .tm_mday = 1,
2170, // year .tm_mon = Month::JANUARY, .tm_year = tm_year(2170), .tm_wday = 0,
1, // month .tm_yday = 0
1, // day };
12, // hr EXPECT_THAT(__llvm_libc::mktime(&tm_data), Succeeds(6311479850));
50, // min EXPECT_TM_EQ((tm{.tm_sec = 50,
50, // sec .tm_min = 50,
0, // wday .tm_hour = 12,
0), // yday .tm_mday = 1,
Succeeds(6311479850)); .tm_mon = Month::JANUARY,
EXPECT_TM_EQ((tm{50, // sec .tm_year = tm_year(2170),
50, // min .tm_wday = 1,
12, // hr .tm_yday = 50}),
1, // day
0, // tm_mon starts with 0 for Jan
2170 - TimeConstants::TIME_YEAR_BASE, // year
1, // wday
50, // yday
0}),
tm_data); tm_data);
}
{
// Test for Tue Jan 1 12:50:50 in 2,147,483,647th year. // Test for Tue Jan 1 12:50:50 in 2,147,483,647th year.
EXPECT_THAT(call_mktime(&tm_data, 2147483647, 1, 1, 12, 50, 50, 0, 0), struct tm tm_data {
Succeeds(67767976202043050)); .tm_sec = 50, .tm_min = 50, .tm_hour = 12, .tm_mday = 1,
EXPECT_TM_EQ((tm{50, // sec .tm_mon = Month::JANUARY, .tm_year = tm_year(2147483647), .tm_wday = 0,
50, // min .tm_yday = 0
12, // hr };
1, // day EXPECT_THAT(__llvm_libc::mktime(&tm_data), Succeeds(67767976202043050));
0, // tm_mon starts with 0 for Jan EXPECT_TM_EQ((tm{.tm_sec = 50,
2147483647 - TimeConstants::TIME_YEAR_BASE, // year .tm_min = 50,
2, // wday .tm_hour = 12,
50, // yday .tm_mday = 1,
0}), .tm_mon = Month::JANUARY,
.tm_year = tm_year(2147483647),
.tm_wday = 2,
.tm_yday = 50}),
tm_data); tm_data);
} }
}