This is an archive of the discontinued LLVM Phabricator instance.

[LSAN] Make sure HWASAN tests are linked with lld
ClosedPublic

Authored by kstoimenov on Feb 17 2023, 11:34 AM.

Diff Detail

Event Timeline

kstoimenov created this revision.Feb 17 2023, 11:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2023, 11:34 AM
Herald added a subscriber: Enna1. · View Herald Transcript
kstoimenov requested review of this revision.Feb 17 2023, 11:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2023, 11:34 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Fixed case.

kstoimenov retitled this revision from [LSAN] Make sure HWASAN tests are linked with lld. to [LSAN] Make sure HWASAN tests are linked with lld.Feb 17 2023, 11:36 AM
kstoimenov added a reviewer: vitalybuka.
vitalybuka added inline comments.Feb 17 2023, 11:43 AM
compiler-rt/test/lsan/lit.common.cfg.py
102

Could you please add into comment why?
Something like "Without D65857, ld.bfd and ld.gold generate corrupted binary "

Updated comment.

Fixed case.

kstoimenov marked an inline comment as done.Feb 17 2023, 11:52 AM
vitalybuka accepted this revision.Feb 22 2023, 11:24 AM
This revision is now accepted and ready to land.Feb 22 2023, 11:24 AM
This revision was automatically updated to reflect the committed changes.