LWG3810 CTAD for std::basic_format_args
Details
- Reviewers
philnik - Group Reviewers
Restricted Project - Commits
- rG8caa8d95afe4: [libc++][format] Addresses LWG3810.
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
LGTM.
libcxx/include/__format/format_args.h | ||
---|---|---|
76 | Was there no test for the CTAD support before? |
Thanks for the review!
libcxx/include/__format/format_args.h | ||
---|---|---|
76 | No that is the "silence the compiler when we want implicit CTAD" version. We don't have tests for these. |
libcxx/include/__format/format_args.h | ||
---|---|---|
76 | I was asked by Louis to add one for the one I added for move_iterator(?). Weird that we don't have tests for all of them. |
libcxx/include/__format/format_args.h | ||
---|---|---|
76 | Thanks, it seems the LWG issue was very useful ;-) |
Was there no test for the CTAD support before?