This is an archive of the discontinued LLVM Phabricator instance.

[Polly][WIP] Use parameter constraints provided via llvm.assume
ClosedPublic

Authored by jdoerfert on Nov 5 2015, 6:32 PM.

Diff Detail

Event Timeline

jdoerfert updated this revision to Diff 39460.Nov 5 2015, 6:32 PM
jdoerfert retitled this revision from to [Polly][WIP] Use parameter constraints provided via llvm.assume.
jdoerfert updated this object.
jdoerfert added reviewers: grosser, Meinersbur.
jdoerfert added a subscriber: Restricted Project.
grosser accepted this revision.Nov 9 2015, 11:42 PM
grosser edited edge metadata.

Hi Johannes,

this patch looks good.

Tobias
PS: Please add next time the tests right away. This would make the review easier and more complete.

lib/Analysis/ScopInfo.cpp
1063

I think using a non-defined TI parameter to look for parameter constraints is rather unexpected. You should at least document this in the function header. Probably even better to understand would be to split this function into the part that creates the ConsequenceSet and the one that adds it
and then create two simple helpers, one for the parameter and one for the non parameter case.

1593

What about adding "ignored":

"Non-affine user assumption ignored"

This revision is now accepted and ready to land.Nov 9 2015, 11:42 PM
This revision was automatically updated to reflect the committed changes.