This is an archive of the discontinued LLVM Phabricator instance.

[ELF][docs] Mention LLD_REPRODUCE and LLD_VERSION
ClosedPublic

Authored by MaskRay on Feb 8 2023, 12:02 PM.

Diff Detail

Event Timeline

MaskRay created this revision.Feb 8 2023, 12:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2023, 12:02 PM
MaskRay requested review of this revision.Feb 8 2023, 12:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2023, 12:02 PM
MaskRay updated this revision to Diff 495916.Feb 8 2023, 12:22 PM

update date

peter.smith accepted this revision.Feb 9 2023, 2:00 AM

LGTM, a couple of small suggestions.

lld/docs/ld.lld.1
7

Did you mean Feb 9, 2023?

892

I recommend changing "indicating its version" to "containing the LLD version string."

The comment for getVersion() says:

// Check LLD_VERSION first for ease of testing.                                                                                                                   // You can get consistent output by using the environment variable.                                                                                               // This is only for testing.

perhaps worth adding. "This option is useful to eliminate differences in the binary caused by LLD version number differences."

This revision is now accepted and ready to land.Feb 9 2023, 2:00 AM
MaskRay updated this revision to Diff 496240.Feb 9 2023, 2:35 PM
MaskRay marked an inline comment as done.

comments

MaskRay updated this revision to Diff 496241.Feb 9 2023, 2:36 PM

fix date

MaskRay added inline comments.Feb 9 2023, 2:38 PM
lld/docs/ld.lld.1
892

Thanks for the suggestion!

This revision was landed with ongoing or failed builds.Feb 9 2023, 2:38 PM
This revision was automatically updated to reflect the committed changes.