This is an archive of the discontinued LLVM Phabricator instance.

Differential D143590

[NFC] Simplify test from change D73904
ClosedPublic

Authored by michaelplatings on Feb 8 2023, 9:05 AM.

Details

Reviewers
amilendra
Commits
rGf28c28e66457: Simplify test from change D73904
Summary

This part of the test can break if multilib is enabled, and isn't
important to testing the change with which is was added.

The relevant part of the test is
ARM-EABI: "-lclang_rt.builtins-arm"
which remains.

Diff Detail

Event Timeline

michaelplatings created this revision.Feb 8 2023, 9:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2023, 9:05 AM
Herald added a subscriber: kristof.beyls. · View Herald Transcript
michaelplatings requested review of this revision.Feb 8 2023, 9:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2023, 9:05 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
amilendra accepted this revision.Feb 8 2023, 9:09 AM
amilendra added a subscriber: amilendra.

LGTM.

This revision is now accepted and ready to land.Feb 8 2023, 9:09 AM
Harbormaster completed remote builds in B212627: Diff 495871.Feb 8 2023, 10:24 AM
Closed by commit rGf28c28e66457: Simplify test from change D73904 (authored by michaelplatings). · Explain WhyFeb 9 2023, 2:05 AM
This revision was automatically updated to reflect the committed changes.
michaelplatings added a commit: rGf28c28e66457: Simplify test from change D73904.

Revision Contents

PathSize
clang/
test/
Driver/
1 line

Diff 496052

clang/test/Driver/arm-compiler-rt.c

// RUN: %clang -target arm-none-eabi \ // RUN: %clang -target arm-none-eabi \
// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \ // RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
// RUN: -rtlib=compiler-rt -### %s 2>&1 \ // RUN: -rtlib=compiler-rt -### %s 2>&1 \
// RUN: | FileCheck %s -check-prefix ARM-EABI // RUN: | FileCheck %s -check-prefix ARM-EABI
// ARM-EABI: "-L{{.*[/\\]}}Inputs/resource_dir_with_arch_subdir{{/|\\\\}}lib{{/|\\\\}}baremetal"
// ARM-EABI: "-lclang_rt.builtins-arm" // ARM-EABI: "-lclang_rt.builtins-arm"
// RUN: %clang -target arm-linux-gnueabi \ // RUN: %clang -target arm-linux-gnueabi \
// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \ // RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
// RUN: -rtlib=compiler-rt -### %s 2>&1 \ // RUN: -rtlib=compiler-rt -### %s 2>&1 \
// RUN: | FileCheck %s -check-prefix ARM-GNUEABI // RUN: | FileCheck %s -check-prefix ARM-GNUEABI
// ARM-GNUEABI: "{{.*[/\\]}}libclang_rt.builtins-arm.a" // ARM-GNUEABI: "{{.*[/\\]}}libclang_rt.builtins-arm.a"
Show All 36 Lines