This is an archive of the discontinued LLVM Phabricator instance.

Differential D143444

[libc] Fix typo is processing LIBC_GPU_TEST_ARCHITECTURE.
ClosedPublic

Authored by sivachandra on Feb 6 2023, 4:18 PM.

Details

Reviewers
jhuber6
Commits
rGc7880f52e43b: [libc] Fix typo is processing LIBC_GPU_TEST_ARCHITECTURE.

Diff Detail

Event Timeline

sivachandra created this revision.Feb 6 2023, 4:18 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 6 2023, 4:18 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
sivachandra requested review of this revision.Feb 6 2023, 4:18 PM
jhuber6 accepted this revision.Feb 6 2023, 4:19 PM

Autocomplete strikes again. Thank you.

This revision is now accepted and ready to land.Feb 6 2023, 4:19 PM
This revision was landed with ongoing or failed builds.Feb 6 2023, 4:21 PM
Closed by commit rGc7880f52e43b: [libc] Fix typo is processing LIBC_GPU_TEST_ARCHITECTURE. (authored by sivachandra). · Explain Why
This revision was automatically updated to reflect the committed changes.
sivachandra added a commit: rGc7880f52e43b: [libc] Fix typo is processing LIBC_GPU_TEST_ARCHITECTURE..
Harbormaster completed remote builds in B212237: Diff 495316.Feb 6 2023, 5:10 PM

Revision Contents

PathSize
libc/
cmake/
modules/
4 lines

Diff 495318

libc/cmake/modules/prepare_libc_gpu_build.cmake

Show All 40 Linesif(NOT LIBC_CLANG_OFFLOAD_PACKAGER)
message(FATAL_ERROR "Cannot find the 'clang-offload-packager' for the GPU " message(FATAL_ERROR "Cannot find the 'clang-offload-packager' for the GPU "
"build") "build")
endif() endif()
set(LIBC_GPU_TEST_ARCHITECTURE "" CACHE STRING "Architecture for the GPU tests") set(LIBC_GPU_TEST_ARCHITECTURE "" CACHE STRING "Architecture for the GPU tests")
if(LIBC_GPU_TEST_ARCHITECTURE) if(LIBC_GPU_TEST_ARCHITECTURE)
message(STATUS "Using user-specified GPU architecture for testing " message(STATUS "Using user-specified GPU architecture for testing "
"'${LIBC_GPU_TARGET_ARCHITECTURE}'") "'${LIBC_GPU_TARGET_ARCHITECTURE}'")
if("${LIBC_GPU_TARGET_ARCHITECTURE}" IN_LIST all_amdgpu_architectures) if("${LIBC_GPU_TEST_ARCHITECTURE}" IN_LIST all_amdgpu_architectures)
set(LIBC_GPU_TARGET_ARCHITECTURE_IS_AMDGPU TRUE) set(LIBC_GPU_TARGET_ARCHITECTURE_IS_AMDGPU TRUE)
set(LIBC_GPU_TARGET_TRIPLE "amdgcn-amd-amdhsa") set(LIBC_GPU_TARGET_TRIPLE "amdgcn-amd-amdhsa")
set(LIBC_GPU_TARGET_ARCHITECTURE "${LIBC_GPU_TEST_ARCHITECTURE}") set(LIBC_GPU_TARGET_ARCHITECTURE "${LIBC_GPU_TEST_ARCHITECTURE}")
elseif("${LIBC_GPU_TARGET_ARCHITECTURE}" IN_LIST all_nvptx_architectures) elseif("${LIBC_GPU_TEST_ARCHITECTURE}" IN_LIST all_nvptx_architectures)
set(LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX TRUE) set(LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX TRUE)
set(LIBC_GPU_TARGET_TRIPLE "nvptx64-nvidia-cuda") set(LIBC_GPU_TARGET_TRIPLE "nvptx64-nvidia-cuda")
set(LIBC_GPU_TARGET_ARCHITECTURE "${LIBC_GPU_TEST_ARCHITECTURE}") set(LIBC_GPU_TARGET_ARCHITECTURE "${LIBC_GPU_TEST_ARCHITECTURE}")
else() else()
message(FATAL_ERROR message(FATAL_ERROR
"Unknown GPU architecture '${LIBC_GPU_TARGET_ARCHITECTURE}'") "Unknown GPU architecture '${LIBC_GPU_TARGET_ARCHITECTURE}'")
endif() endif()
return() return()
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines