This is an archive of the discontinued LLVM Phabricator instance.

[HWASAN] Remove GetRequestedSize check from Metadata::IsAllocated
ClosedPublic

Authored by kstoimenov on Feb 6 2023, 4:03 PM.

Details

Summary

After D143438 there is no point in this check as the size will never 0. Also this keeps it consistent with ASAN where there is not size check in LsanMetadata::allocated.

Diff Detail

Event Timeline

kstoimenov created this revision.Feb 6 2023, 4:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2023, 4:03 PM
Herald added a subscriber: Enna1. · View Herald Transcript
kstoimenov requested review of this revision.Feb 6 2023, 4:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2023, 4:03 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kstoimenov retitled this revision from [HWASAN] Remove GetRequestedSize from Metadata::IsAllocated to [HWASAN] Remove GetRequestedSize check from Metadata::IsAllocated.Feb 6 2023, 4:04 PM
kstoimenov edited the summary of this revision. (Show Details)
kstoimenov added reviewers: MaskRay, vitalybuka.
vitalybuka accepted this revision.Feb 6 2023, 4:07 PM
This revision is now accepted and ready to land.Feb 6 2023, 4:07 PM
kstoimenov edited the summary of this revision. (Show Details)Feb 6 2023, 4:08 PM
MaskRay accepted this revision.Feb 6 2023, 4:23 PM
This revision was landed with ongoing or failed builds.Feb 7 2023, 7:52 AM
This revision was automatically updated to reflect the committed changes.