This is an archive of the discontinued LLVM Phabricator instance.

Asan: utility function to determine first wrongly poisoned byte in container.
ClosedPublic

Authored by aizatsky on Nov 4 2015, 11:04 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

aizatsky updated this revision to Diff 39221.Nov 4 2015, 11:04 AM
aizatsky retitled this revision from to std_string supporting functions.
aizatsky updated this object.
aizatsky retitled this revision from std_string supporting functions to Asan: utility function to determine first wrongly poisoned byte in container..Nov 4 2015, 11:10 AM
aizatsky added a reviewer: kcc.
aizatsky added a subscriber: llvm-commits.
kcc added inline comments.Nov 4 2015, 11:21 AM
include/sanitizer/common_interface_defs.h
108 ↗(On Diff #39221)

Maybe find_first_bad_address?
Also, add a comment please.

aizatsky updated this revision to Diff 39227.Nov 4 2015, 11:27 AM

comment fix.

Sorry, had old version uploaded. PTAL.

include/sanitizer/common_interface_defs.h
108–115 ↗(On Diff #39226)

I think the name is too long already :)

kcc accepted this revision.Nov 4 2015, 11:30 AM
kcc edited edge metadata.

LGTM, but please also add a test for this function (to test/asan/TestCases/contiguous_container.cc)

This revision is now accepted and ready to land.Nov 4 2015, 11:30 AM
aizatsky updated this revision to Diff 39235.Nov 4 2015, 11:52 AM
aizatsky edited edge metadata.

added test.

test added. submitting.

This revision was automatically updated to reflect the committed changes.