Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/tools/include-mapping/gen_std.py | ||
---|---|---|
162 | i think putting iostream before iosfwd in the alternative list makes more sense. WDYT? | |
218–221 | what about changing this to: symbol.headers.extend(AdditionalHeadersForIOSymbols(symbol)) for header in symbol.headers: .... (and also changing AdditionalHeadersForIOSymbols to only return additional headers and an empty list if there's none) that way it'll be easier to augment symbol headers later on. |
thanks, lgtm! as discussed offline, let's first move the raw header mappings to a private location first though and make sure all users are going through stdlib apis to ensure we don't see weird behaviour after such changes (since we're breaking the invariant of a qualified symbol name occurring only once)
i think putting iostream before iosfwd in the alternative list makes more sense. WDYT?