This is an archive of the discontinued LLVM Phabricator instance.

[GWP-ASan] Remove thread clamping in tests.
ClosedPublic

Authored by hctim on Feb 2 2023, 3:21 PM.

Details

Summary

It's better and easier for us to just have threads contend against each
other in the tests if it's more than the maximum supported number of
hardware threads available.

Specifically, the recoverable test fails on Android because the
GTEST_SKIP in a called function, and it only properly works from the
TEST_* harness function. Android tests run on cuttlefish, which can be a
single core with two hyperthreads.

Diff Detail

Event Timeline

hctim created this revision.Feb 2 2023, 3:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2023, 3:21 PM
Herald added a subscriber: Enna1. · View Herald Transcript
hctim requested review of this revision.Feb 2 2023, 3:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2023, 3:21 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
fmayer accepted this revision.Feb 2 2023, 3:26 PM
This revision is now accepted and ready to land.Feb 2 2023, 3:26 PM
This revision was landed with ongoing or failed builds.Feb 2 2023, 3:40 PM
This revision was automatically updated to reflect the committed changes.