This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Add split-file as runtime test dependency
ClosedPublic

Authored by yozhu on Feb 1 2023, 4:34 PM.

Details

Summary

Here is a similar change that adds split-file as compiler-rt test dependency: https://reviews.llvm.org/rG0eb01a9c4581a24c163f3464cebdb20534fbda35

Diff Detail

Event Timeline

yozhu created this revision.Feb 1 2023, 4:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2023, 4:34 PM
yozhu requested review of this revision.Feb 1 2023, 4:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2023, 4:34 PM
thevinster accepted this revision.Feb 1 2023, 7:04 PM

LGTM. Not sure why buildbots are complaining, but they don't look super related.

Could you update the summary mentioning the diff that added the split-file dependency on the check-profile target for future readers?

This revision is now accepted and ready to land.Feb 1 2023, 7:04 PM
yozhu edited the summary of this revision. (Show Details)Feb 1 2023, 8:52 PM
yozhu edited the summary of this revision. (Show Details)
yozhu updated this revision to Diff 494156.Feb 1 2023, 9:01 PM

Add split-file as compiler-rt test dependency under clang/runtime

Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2023, 9:01 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision was automatically updated to reflect the committed changes.