Page MenuHomePhabricator
Differential D143088

[CMake] Save and restore CMAKE_EXE_LINKER_FLAGS manually
ClosedPublic
Actions

Authored by phosek on Feb 1 2023, 9:32 AM.

Details

Reviewers
mstorsjo
Commits
rG9b94a67f8232: [CMake] Save and restore CMAKE_EXE_LINKER_FLAGS manually
Summary

cmake_push_check_state and cmake_pop_check_state doesn't save and
restore CMAKE_EXE_LINKER_FLAGS so we need to do it manually.

Diff Detail

Event Timeline

phosek created this revision.Feb 1 2023, 9:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2023, 9:32 AM
phosek requested review of this revision.Feb 1 2023, 9:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2023, 9:32 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
phosek mentioned this in D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag.Feb 1 2023, 9:38 AM
mstorsjo accepted this revision.Feb 1 2023, 9:51 AM

LGTM

This revision is now accepted and ready to land.Feb 1 2023, 9:51 AM
This revision was landed with ongoing or failed builds.Feb 1 2023, 10:05 AM
Closed by commit rG9b94a67f8232: [CMake] Save and restore CMAKE_EXE_LINKER_FLAGS manually (authored by phosek). · Explain Why
This revision was automatically updated to reflect the committed changes.
phosek added a commit: rG9b94a67f8232: [CMake] Save and restore CMAKE_EXE_LINKER_FLAGS manually.
Harbormaster completed remote builds in B211260: Diff 493987.Feb 1 2023, 10:43 AM

Revision Contents
Changeset List

PathSize
llvm/
cmake/
modules/
5 lines

Diff 493998

View Options

llvm/cmake/modules/LLVMCheckLinkerFlag.cmake

Loading...