This is an archive of the discontinued LLVM Phabricator instance.

Differential D143047

Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux-perf builder
ClosedPublic

Authored by yinyangsx on Jan 31 2023, 11:27 PM.

Details

Reviewers
gkistanova
Commits
rZORG0cc50a77ae86: Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux-perf…
Summary

According to LNT test doc, the autoconfigure support is deprecated, so this patch is for using cmake instead for "clang-cmake-x86_64-avx2-linux-perf" builder.

Diff Detail

Event Timeline

yinyangsx created this revision.Jan 31 2023, 11:27 PM
Herald added a reviewer: gkistanova. · View Herald TranscriptJan 31 2023, 11:27 PM
Herald added a project: Restricted Project. · View Herald Transcript
yinyangsx requested review of this revision.Jan 31 2023, 11:27 PM
Harbormaster completed remote builds in B211151: Diff 493838.Jan 31 2023, 11:27 PM
yinyangsx edited the summary of this revision. (Show Details)Jan 31 2023, 11:29 PM
Herald added a subscriber: pengfei. · View Herald TranscriptJan 31 2023, 11:29 PM
yinyangsx retitled this revision from Switch from atuoconfigure to cmake for clang-cmake-x86_64-avx2-linux-perf builder to Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux-perf builder.Jan 31 2023, 11:30 PM
gkistanova accepted this revision.Feb 1 2023, 11:27 PM

LGTM.

This revision is now accepted and ready to land.Feb 1 2023, 11:27 PM
pengfei added inline comments.Feb 1 2023, 11:40 PM
buildbot/osuosl/master/config/builders.py
886

Cascadelake?

yinyangsx updated this revision to Diff 494490.Feb 2 2023, 6:37 PM

Update tester name

Harbormaster completed remote builds in B211629: Diff 494490.Feb 2 2023, 6:37 PM
yinyangsx marked an inline comment as done.Feb 2 2023, 6:39 PM
yinyangsx added inline comments.
buildbot/osuosl/master/config/builders.py
886

Yes, thank you for remaining

yinyangsx marked an inline comment as done.Feb 2 2023, 6:39 PM
yinyangsx added a comment.Feb 5 2023, 5:49 PM

Hi @gkistanova, this change is ready, could you please land this change?

Closed by commit rZORG0cc50a77ae86: Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux-perf… (authored by yinyangsx, committed by gkistanova). · Explain WhyFeb 6 2023, 9:31 PM
This revision was automatically updated to reflect the committed changes.
gkistanova added a commit: rZORG0cc50a77ae86: Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux-perf….
yinyangsx added a comment.Feb 6 2023, 10:37 PM

Hi @gkistanova, after patch landed, how long the BB master will apply it?

gkistanova added a comment.Feb 7 2023, 10:14 AM

Feel free to connect your worker to the staging.

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
10 lines

Diff 493838

buildbot/osuosl/master/config/builders.py

Show First 20 Lines • Show All 869 Lines • ▼ Show 20 Lines# Clang builders.
'factory' : ClangBuilder.getClangCMakeBuildFactory( 'factory' : ClangBuilder.getClangCMakeBuildFactory(
clean=False, clean=False,
checkout_clang_tools_extra=False, checkout_clang_tools_extra=False,
checkout_compiler_rt=False, checkout_compiler_rt=False,
checkout_lld=False, checkout_lld=False,
checks=[], checks=[],
useTwoStage=False, useTwoStage=False,
runTestSuite=True, runTestSuite=True,
nt_flags=['--cflag', '-march=broadwell', '--threads=1', '--build-threads=80', '--use-perf', testsuite_flags=['--cflag', '-march=cascadelake', '--threads=1', '--build-threads=32', '--use-perf=all',
'--benchmarking-only', '--multisample=4', '--exclude-stat-from-submission=compile'], '--benchmarking-only', '--exec-multisample=4', '--exclude-stat-from-submission=compile'],
env={'PATH':'/usr/bin/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'}, env={'PATH':'/usr/bin/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'},
extra_cmake_args=[ extra_cmake_args=[
"-DCMAKE_C_FLAGS='-march=broadwell'", "-DCMAKE_C_FLAGS='-march=cascadelake'",
"-DCMAKE_CXX_FLAGS='-march=broadwell'", "-DCMAKE_CXX_FLAGS='-march=cascadelake'",
"-DLLVM_TARGETS_TO_BUILD='X86'"], "-DLLVM_TARGETS_TO_BUILD='X86'"],
submitURL='http://lnt.llvm.org/submitRun', submitURL='http://lnt.llvm.org/submitRun',
testerName='LNT-Broadwell-AVX2-O5')}, testerName='LNT-Broadwell-AVX2-O6')},
pengfeiUnsubmitted
Done
ReplyInline Actions

Cascadelake?

pengfei: Cascadelake?
yinyangsxAuthorUnsubmitted
Done
ReplyInline Actions

Yes, thank you for remaining

yinyangsx: Yes, thank you for remaining
## X86_64 Clang+LLVM Run test-suite targeting AVX512 on SDE (Emulator) ## X86_64 Clang+LLVM Run test-suite targeting AVX512 on SDE (Emulator)
{'name' : "clang-cmake-x86_64-sde-avx512-linux", {'name' : "clang-cmake-x86_64-sde-avx512-linux",
'tags' : ["clang"], 'tags' : ["clang"],
'workernames' : ["sde-avx512-intel64"], 'workernames' : ["sde-avx512-intel64"],
'builddir': "clang-cmake-x86_64-sde-avx512-linux", 'builddir': "clang-cmake-x86_64-sde-avx512-linux",
'factory' : ClangBuilder.getClangCMakeBuildFactory( 'factory' : ClangBuilder.getClangCMakeBuildFactory(
clean=False, clean=False,
▲ Show 20 Lines • Show All 1,876 Lines • Show Last 20 Lines