This is an archive of the discontinued LLVM Phabricator instance.

Differential D143045

Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux builder
ClosedPublic

Authored by yinyangsx on Jan 31 2023, 10:38 PM.

Details

Reviewers
gkistanova
Commits
rZORG7986e6372b36: Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux builder
Summary

According to LNT test doc, the autoconfigure support is deprecated, so this patch is for using cmake instead for "clang-cmake-x86_64-avx2-linux" builder.

Diff Detail

Event Timeline

yinyangsx created this revision.Jan 31 2023, 10:38 PM
Herald added a reviewer: gkistanova. · View Herald TranscriptJan 31 2023, 10:38 PM
Herald added a project: Restricted Project. · View Herald Transcript
yinyangsx requested review of this revision.Jan 31 2023, 10:38 PM
Harbormaster completed remote builds in B211145: Diff 493827.Jan 31 2023, 10:38 PM
yinyangsx retitled this revision from Switch from Makefile test-suite to cmake test-suite for clang-cmake-x86_64-avx2-linux builder to Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux builder.Jan 31 2023, 11:03 PM
yinyangsx edited the summary of this revision. (Show Details)
Herald added a subscriber: pengfei. · View Herald TranscriptJan 31 2023, 11:03 PM
gkistanova accepted this revision.Feb 1 2023, 11:36 PM

LGTM.

This revision is now accepted and ready to land.Feb 1 2023, 11:36 PM
yinyangsx added a comment.Feb 2 2023, 7:00 PM

Hi @gkistanova, could you please help land this change? Seems I have no permission to land.

Closed by commit rZORG7986e6372b36: Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux builder (authored by yinyangsx, committed by gkistanova). · Explain WhyFeb 3 2023, 12:14 AM
This revision was automatically updated to reflect the committed changes.
gkistanova added a commit: rZORG7986e6372b36: Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux builder.

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
8 lines

Diff 493827

buildbot/osuosl/master/config/builders.py

Show First 20 Lines • Show All 839 Lines • ▼ Show 20 Lines 'factory' : ClangBuilder.getClangCMakeBuildFactory(
"-DLINK_POLLY_INTO_TOOLS:BOOL=OFF", "-DLINK_POLLY_INTO_TOOLS:BOOL=OFF",
"-DPOLLY_BUILD_SHARED_LIB:BOOL=OFF", "-DPOLLY_BUILD_SHARED_LIB:BOOL=OFF",
"-DCMAKE_C_COMPILER:FILEPATH=/local/clang+llvm-12.0.0-x86_64-linux-gnu-ubuntu-16.04/bin/clang", "-DCMAKE_C_COMPILER:FILEPATH=/local/clang+llvm-12.0.0-x86_64-linux-gnu-ubuntu-16.04/bin/clang",
"-DCMAKE_CXX_COMPILER:FILEPATH=/local/clang+llvm-12.0.0-x86_64-linux-gnu-ubuntu-16.04/bin/clang++"])}, "-DCMAKE_CXX_COMPILER:FILEPATH=/local/clang+llvm-12.0.0-x86_64-linux-gnu-ubuntu-16.04/bin/clang++"])},
## X86_64 AVX2 Clang+LLVM check-all + test-suite ## X86_64 AVX2 Clang+LLVM check-all + test-suite
{'name' : "clang-cmake-x86_64-avx2-linux", {'name' : "clang-cmake-x86_64-avx2-linux",
'tags' : ["clang"], 'tags' : ["clang"],
'workernames' : ["avx2-intel64"], 'workernames' : ["sde-avx512-intel64"],
'builddir': "clang-cmake-x86_64-avx2-linux", 'builddir': "clang-cmake-x86_64-avx2-linux",
'factory' : ClangBuilder.getClangCMakeBuildFactory( 'factory' : ClangBuilder.getClangCMakeBuildFactory(
clean=False, clean=False,
checkout_clang_tools_extra=False, checkout_clang_tools_extra=False,
checkout_compiler_rt=False, checkout_compiler_rt=False,
checkout_lld=False, checkout_lld=False,
useTwoStage=False, useTwoStage=False,
runTestSuite=True, runTestSuite=True,
nt_flags=['--cflag', '-march=broadwell', '--threads=80', '--build-threads=80'], testsuite_flags=['--cflag', '-march=cascadelake', '--threads=32', '--build-threads=32'],
env={'PATH':'/usr/bin/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'}, env={'PATH':'/usr/bin/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'},
extra_cmake_args=[ extra_cmake_args=[
"-DLLVM_ENABLE_ASSERTIONS=ON", "-DLLVM_ENABLE_ASSERTIONS=ON",
"-DCMAKE_C_FLAGS='-march=broadwell'", "-DCMAKE_C_FLAGS='-march=cascadelake'",
"-DCMAKE_CXX_FLAGS='-march=broadwell'", "-DCMAKE_CXX_FLAGS='-march=cascadelake'",
"-DLLVM_TARGETS_TO_BUILD='X86'"])}, "-DLLVM_TARGETS_TO_BUILD='X86'"])},
## X86_64 AVX2 LNT test-suite in Benchmark mode ## X86_64 AVX2 LNT test-suite in Benchmark mode
{'name' : "clang-cmake-x86_64-avx2-linux-perf", {'name' : "clang-cmake-x86_64-avx2-linux-perf",
'tags' : ["clang"], 'tags' : ["clang"],
'workernames' : ["avx2-intel64"], 'workernames' : ["avx2-intel64"],
'builddir': "clang-cmake-x86_64-avx2-linux-perf", 'builddir': "clang-cmake-x86_64-avx2-linux-perf",
'factory' : ClangBuilder.getClangCMakeBuildFactory( 'factory' : ClangBuilder.getClangCMakeBuildFactory(
▲ Show 20 Lines • Show All 1,900 Lines • Show Last 20 Lines