This is an archive of the discontinued LLVM Phabricator instance.

Differential D142944

[Doc] Removes extra argument of ReplaceInstWithValue()
ClosedPublic

Authored by vporpo on Jan 30 2023, 5:14 PM.

Details

Reviewers
dbabokin
Commits
rG279f262d497e: [Doc] Removes extra argument of ReplaceInstWithValue()

Diff Detail

Event Timeline

vporpo created this revision.Jan 30 2023, 5:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 30 2023, 5:14 PM
vporpo requested review of this revision.Jan 30 2023, 5:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 30 2023, 5:14 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
dbabokin added inline comments.Jan 30 2023, 5:30 PM
llvm/docs/ProgrammersManual.rst
2959–2960

Should the arguments go on the same line now?

vporpo added inline comments.Jan 30 2023, 5:35 PM
llvm/docs/ProgrammersManual.rst
2959–2960

It is already > 80 columns wide, so yeah why not.

vporpo updated this revision to Diff 493460.Jan 30 2023, 5:36 PM

Removed newline

dbabokin accepted this revision.Jan 30 2023, 5:47 PM

LGTM

This revision is now accepted and ready to land.Jan 30 2023, 5:47 PM
Harbormaster completed remote builds in B210888: Diff 493460.Jan 30 2023, 6:43 PM
Closed by commit rG279f262d497e: [Doc] Removes extra argument of ReplaceInstWithValue() (authored by vporpo). · Explain WhyJan 30 2023, 7:04 PM
This revision was automatically updated to reflect the committed changes.
vporpo added a commit: rG279f262d497e: [Doc] Removes extra argument of ReplaceInstWithValue().

Revision Contents

PathSize
llvm/
docs/
3 lines

Diff 493471

llvm/docs/ProgrammersManual.rst

Show First 20 Lines • Show All 2,950 Lines • ▼ Show 20 Lines* ``ReplaceInstWithValue``
replacement of the result of a particular ``AllocaInst`` that allocates memory replacement of the result of a particular ``AllocaInst`` that allocates memory
for a single integer with a null pointer to an integer. for a single integer with a null pointer to an integer.
.. code-block:: c++ .. code-block:: c++
AllocaInst* instToReplace = ...; AllocaInst* instToReplace = ...;
BasicBlock::iterator ii(instToReplace); BasicBlock::iterator ii(instToReplace);
ReplaceInstWithValue(instToReplace->getParent(), ii, ReplaceInstWithValue(ii, Constant::getNullValue(PointerType::getUnqual(Type::Int32Ty)));
Constant::getNullValue(PointerType::getUnqual(Type::Int32Ty)));
dbabokinUnsubmitted
Not Done
ReplyInline Actions
BasicBlock::iterator ii(instToReplace);
- ReplaceInstWithValue(instToReplace->getParent(), ii,
- Constant::getNullValue(PointerType::getUnqual(Type::Int32Ty)));
+ ReplaceInstWithValue(ii, Constant::getNullValue(PointerType::getUnqual(Type::Int32Ty)));
* ``ReplaceInstWithInst``

Should the arguments go on the same line now?

dbabokin: Should the arguments go on the same line now?
vporpoAuthorUnsubmitted
Done
ReplyInline Actions

It is already > 80 columns wide, so yeah why not.

vporpo: It is already > 80 columns wide, so yeah why not.
* ``ReplaceInstWithInst`` * ``ReplaceInstWithInst``
This function replaces a particular instruction with another instruction, This function replaces a particular instruction with another instruction,
inserting the new instruction into the basic block at the location where the inserting the new instruction into the basic block at the location where the
old instruction was, and replacing any uses of the old instruction with the old instruction was, and replacing any uses of the old instruction with the
new instruction. The following example illustrates the replacement of one new instruction. The following example illustrates the replacement of one
``AllocaInst`` with another. ``AllocaInst`` with another.
▲ Show 20 Lines • Show All 1,083 Lines • Show Last 20 Lines