This is an archive of the discontinued LLVM Phabricator instance.

[BigArchive][NFC] Enhance test cases introduced in D138986
AbandonedPublic

Authored by lkail on Jan 30 2023, 3:56 AM.

Details

Reviewers
jhenderson
Group Reviewers
Restricted Project
Summary

Per @jhenderson 's comments, update test cases.

Diff Detail

Event Timeline

lkail created this revision.Jan 30 2023, 3:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 30 2023, 3:56 AM
lkail requested review of this revision.Jan 30 2023, 3:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 30 2023, 3:56 AM
lkail updated this revision to Diff 493272.Jan 30 2023, 3:59 AM
jhenderson accepted this revision.Jan 30 2023, 5:24 AM

Looks good, with one optional suggestion.

llvm/test/Object/archive-big-read-empty-with-freelist.test
2

If you'd like to verify that the output is empty, you can add | count 0 to the end of this line (see other examples in the lit tests again).

This revision is now accepted and ready to land.Jan 30 2023, 5:24 AM
lkail abandoned this revision.Jan 31 2023, 6:15 AM

Changes are included in https://reviews.llvm.org/D138986.