[lldb][NFC] Use move instead of copy

[ccotter]

Summary

For functions that accept an rvalue reference type
parameter, use move to avoid copying the parameter.

These were found when implementing CppCoreGuideline F.18 in
clang-tidy.

[ccotter]

Thanks! I don't have push access, so if you're good with this, could you please land this for me?

[Michael137]

In D142824#4095360, @ccotter wrote:

Thanks! I don't have push access, so if you're good with this, could you please land this for me?

Sure, could you let me know which email and name you'd like me to use in the commit?

[ccotter]

This should do: Chris Cotter <[e-mail]>

thanks

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp

if (pid != LLDB_INVALID_PROCESS_ID) {
     std::lock_guard<std::recursive_mutex> guard(m_spawned_pids_mutex);
     m_spawned_pids.insert(pid);
   }
 
   return error;
 }
 
 void GDBRemoteCommunicationServerPlatform::SetPortMap(PortMap &&port_map) {
-  m_port_map = port_map;
+  m_port_map = std::move(port_map);
 }
 
 const FileSpec &GDBRemoteCommunicationServerPlatform::GetDomainSocketDir() {
   static FileSpec g_domainsocket_dir;
   static llvm::once_flag g_once_flag;
 
   llvm::call_once(g_once_flag, []() {
     const char *domainsocket_dir_env =

lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp

 void TraceHTR::AddNewBlockLayer(HTRBlockLayerUP &&block_layer) {
   m_block_layer_ups.emplace_back(std::move(block_layer));
 }
 
 size_t IHTRLayer::GetLayerId() const { return m_layer_id; }
 
 void HTRBlockLayer::AppendNewBlock(size_t block_id, HTRBlock &&block) {
   m_block_id_trace.emplace_back(block_id);
-  m_block_defs.emplace(block_id, block);
+  m_block_defs.emplace(block_id, std::move(block));
 }
 
 void HTRBlockLayer::AppendRepeatedBlock(size_t block_id) {
   m_block_id_trace.emplace_back(block_id);
 }
 
 llvm::ArrayRef<lldb::addr_t> HTRInstructionLayer::GetInstructionTrace() const {
   return m_instruction_trace;

lldb/source/Target/Process.cpp

if (error.Success()) {
     if (error.Success())
       DidSignal();
   }
   return error;
 }
 
 void Process::SetUnixSignals(UnixSignalsSP &&signals_sp) {
   assert(signals_sp && "null signals_sp");
-  m_unix_signals_sp = signals_sp;
+  m_unix_signals_sp = std::move(signals_sp);
 }
 
 const lldb::UnixSignalsSP &Process::GetUnixSignals() {
   assert(m_unix_signals_sp && "null m_unix_signals_sp");
   return m_unix_signals_sp;
 }
 
 lldb::ByteOrder Process::GetByteOrder() const {