This is an archive of the discontinued LLVM Phabricator instance.

[lldb][NFC] Use move instead of copy
ClosedPublic

Authored by ccotter on Jan 28 2023, 5:54 PM.

Details

Summary

For functions that accept an rvalue reference type
parameter, use move to avoid copying the parameter.

These were found when implementing CppCoreGuideline F.18 in
clang-tidy.

Diff Detail

Event Timeline

ccotter created this revision.Jan 28 2023, 5:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2023, 5:54 PM
ccotter requested review of this revision.Jan 28 2023, 5:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2023, 5:54 PM
Michael137 accepted this revision.Jan 31 2023, 5:32 PM
This revision is now accepted and ready to land.Jan 31 2023, 5:32 PM

Thanks! I don't have push access, so if you're good with this, could you please land this for me?

Thanks! I don't have push access, so if you're good with this, could you please land this for me?

Sure, could you let me know which email and name you'd like me to use in the commit?

This should do: Chris Cotter <ccotter14@bloomberg.net>

thanks

This revision was automatically updated to reflect the committed changes.