Page MenuHomePhabricator
Differential D142824

[lldb][NFC] Use move instead of copy
ClosedPublic
Actions

Authored by ccotter on Jan 28 2023, 5:54 PM.

Details

Reviewers
aprantl
Michael137
Commits
rG6953dc95a976: [lldb][NFC] Use move instead of copy
Summary

For functions that accept an rvalue reference type
parameter, use move to avoid copying the parameter.

These were found when implementing CppCoreGuideline F.18 in
clang-tidy.

Diff Detail

Event Timeline

ccotter created this revision.Jan 28 2023, 5:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2023, 5:54 PM
ccotter requested review of this revision.Jan 28 2023, 5:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2023, 5:54 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B210573: Diff 493048.Jan 28 2023, 5:57 PM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptJan 28 2023, 5:57 PM
ccotter added a reviewer: aprantl.Jan 31 2023, 5:28 PM
Michael137 accepted this revision.Jan 31 2023, 5:32 PM
This revision is now accepted and ready to land.Jan 31 2023, 5:32 PM
ccotter added a comment.Jan 31 2023, 5:44 PM

Thanks! I don't have push access, so if you're good with this, could you please land this for me?

Michael137 added a comment.Feb 1 2023, 6:39 AM
In D142824#4095360, @ccotter wrote:

Thanks! I don't have push access, so if you're good with this, could you please land this for me?

Sure, could you let me know which email and name you'd like me to use in the commit?

ccotter added a comment.Feb 1 2023, 7:30 AM

This should do: Chris Cotter <ccotter14@bloomberg.net>

thanks

Closed by commit rG6953dc95a976: [lldb][NFC] Use move instead of copy (authored by ccotter, committed by Michael137). · Explain WhyFeb 1 2023, 7:52 AM
This revision was automatically updated to reflect the committed changes.
Michael137 added a commit: rG6953dc95a976: [lldb][NFC] Use move instead of copy.
ccotter mentioned this in D141569: [clang-tidy] Implement CppCoreGuideline F.18.Feb 16 2023, 8:26 PM

Revision Contents
Changeset List

PathSize
lldb/
source/
Plugins/
Process/
gdb-remote/
2 lines
TraceExporter/
common/
2 lines
Target/
2 lines

Diff 493946

View Options

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp

Loading...
View Options

lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp

Loading...
View Options

lldb/source/Target/Process.cpp

Loading...