This is an archive of the discontinued LLVM Phabricator instance.

[libc++][ranges] Addresses LWG3759
ClosedPublic

Authored by Mordante on Jan 28 2023, 9:18 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG6b4bb103db37: [libc++][ranges] Addresses LWG3759
Summary
LWG3759 ranges::rotate_copy should use std::move

This has been one in the initial version (D127211).

Diff Detail

Event Timeline

Mordante created this revision.Jan 28 2023, 9:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2023, 9:18 AM
Mordante requested review of this revision.Jan 28 2023, 9:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2023, 9:18 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Do we have a test for this?

ldionne accepted this revision.May 2 2023, 2:43 PM

I just checked and we do. We have a test with cpp20_output_iterator, which is move-only.

This revision is now accepted and ready to land.May 2 2023, 2:43 PM

Thanks for the review, it somehow dropped of my review list.

This revision was automatically updated to reflect the committed changes.