This is an archive of the discontinued LLVM Phabricator instance.

Differential D142812

[LSAN] Remove -fuse-ld=lld from HWASAN config
ClosedPublic

Authored by kstoimenov on Jan 28 2023, 7:58 AM.

Details

Reviewers
kstoimenov
Commits
rGbf47ffaa76fb: [LSAN] Remove -fuse-ld=lld from HWASAN config
Summary

I needed that to make -fsanitize-hwaddress-experimental-aliasing work, but it looks like the test pass without it also. This should fix https://lab.llvm.org/buildbot/#/builders/192 failures.

Diff Detail

Event Timeline

kstoimenov created this revision.Jan 28 2023, 7:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2023, 7:58 AM
Herald added a subscriber: Enna1. · View Herald Transcript
kstoimenov requested review of this revision.Jan 28 2023, 7:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2023, 7:58 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kstoimenov accepted this revision.Jan 28 2023, 7:59 AM
kstoimenov edited the summary of this revision. (Show Details)
kstoimenov added a reviewer: kstoimenov.
This revision is now accepted and ready to land.Jan 28 2023, 8:00 AM
This revision was landed with ongoing or failed builds.Jan 28 2023, 8:08 AM
Closed by commit rGbf47ffaa76fb: [LSAN] Remove -fuse-ld=lld from HWASAN config (authored by kstoimenov). · Explain Why
This revision was automatically updated to reflect the committed changes.
kstoimenov added a commit: rGbf47ffaa76fb: [LSAN] Remove -fuse-ld=lld from HWASAN config.
Harbormaster completed remote builds in B210544: Diff 493006.Jan 28 2023, 8:16 AM
kstoimenov added a subscriber: vitalybuka.Jan 28 2023, 8:49 AM
hans mentioned this in rG3b9606b5cbf6: Revert "[LSAN][HWASAN] Run LSAN tests with HWASAN enabled".Jan 30 2023, 11:57 AM

Revision Contents

PathSize
compiler-rt/
test/
lsan/
3 lines

Diff 493007

compiler-rt/test/lsan/lit.common.cfg.py

Show All 30 Lineselif lsan_lit_test_mode == "AddressSanitizer":
lsan_cflags = ["-fsanitize=address"] lsan_cflags = ["-fsanitize=address"]
config.available_features.add('asan') config.available_features.add('asan')
if config.host_os == 'NetBSD': if config.host_os == 'NetBSD':
config.substitutions.insert(0, ('%run', config.netbsd_noaslr_prefix)) config.substitutions.insert(0, ('%run', config.netbsd_noaslr_prefix))
elif lsan_lit_test_mode == "HWAddressSanitizer": elif lsan_lit_test_mode == "HWAddressSanitizer":
config.name = "LeakSanitizer-HWAddressSanitizer" config.name = "LeakSanitizer-HWAddressSanitizer"
lsan_cflags = ["-fsanitize=hwaddress"] lsan_cflags = ["-fsanitize=hwaddress"]
if target_arch == "x86_64": if target_arch == "x86_64":
lsan_cflags = lsan_cflags + ['-fuse-ld=lld', lsan_cflags = lsan_cflags + [ '-fsanitize-hwaddress-experimental-aliasing']
'-fsanitize-hwaddress-experimental-aliasing']
config.available_features.add('hwasan') config.available_features.add('hwasan')
if config.host_os == 'NetBSD': if config.host_os == 'NetBSD':
config.substitutions.insert(0, ('%run', config.netbsd_noaslr_prefix)) config.substitutions.insert(0, ('%run', config.netbsd_noaslr_prefix))
else: else:
lit_config.fatal("Unknown LSan test mode: %r" % lsan_lit_test_mode) lit_config.fatal("Unknown LSan test mode: %r" % lsan_lit_test_mode)
config.name += config.name_suffix config.name += config.name_suffix
# Platform-specific default LSAN_OPTIONS for lit tests. # Platform-specific default LSAN_OPTIONS for lit tests.
▲ Show 20 Lines • Show All 54 Lines • Show Last 20 Lines