This is an archive of the discontinued LLVM Phabricator instance.

Differential D142720

libclc: Set CMAKE_CXX_STANDARD to 17 to match llvm
ClosedPublic

Authored by tstellar on Jan 27 2023, 6:34 AM.

Details

Reviewers
thieta
Commits
rG409f42b10ac6: libclc: Set CMAKE_CXX_STANDARD to 17 to match llvm

Diff Detail

Event Timeline

tstellar created this revision.Jan 27 2023, 6:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2023, 6:34 AM
Herald added a subscriber: jvesely. · View Herald Transcript
tstellar requested review of this revision.Jan 27 2023, 6:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2023, 6:34 AM
thieta accepted this revision.Jan 27 2023, 6:39 AM

we really should centralize the C++ standard variable in top-level cmake or llvm.

This revision is now accepted and ready to land.Jan 27 2023, 6:39 AM
Harbormaster completed remote builds in B210350: Diff 492739.Jan 27 2023, 7:35 AM
Closed by commit rG409f42b10ac6: libclc: Set CMAKE_CXX_STANDARD to 17 to match llvm (authored by tstellar). · Explain WhyJan 27 2023, 10:50 AM
This revision was automatically updated to reflect the committed changes.
tstellar added a commit: rG409f42b10ac6: libclc: Set CMAKE_CXX_STANDARD to 17 to match llvm.

Revision Contents

PathSize
libclc/
2 lines

Diff 492846

libclc/CMakeLists.txt

cmake_minimum_required(VERSION 3.13.4) cmake_minimum_required(VERSION 3.13.4)
project( libclc VERSION 0.2.0 LANGUAGES CXX C) project( libclc VERSION 0.2.0 LANGUAGES CXX C)
set(CMAKE_CXX_STANDARD 17)
include( GNUInstallDirs ) include( GNUInstallDirs )
set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS
amdgcn-amdhsa/lib/SOURCES; amdgcn-amdhsa/lib/SOURCES;
amdgcn/lib/SOURCES; amdgcn/lib/SOURCES;
amdgcn-mesa3d/lib/SOURCES; amdgcn-mesa3d/lib/SOURCES;
amdgpu/lib/SOURCES; amdgpu/lib/SOURCES;
clspv/lib/SOURCES; clspv/lib/SOURCES;
clspv64/lib/SOURCES; clspv64/lib/SOURCES;
▲ Show 20 Lines • Show All 340 Lines • Show Last 20 Lines