This is an archive of the discontinued LLVM Phabricator instance.

Differential D142657

[libc++] Add missing include promote.h in <cmath>
ClosedPublic

Authored by ldionne on Jan 26 2023, 11:47 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rGbab1a14cccd4: [libc++] Add missing include promote.h in <cmath>

Diff Detail

Unit TestsFailed

TimeTest
1,500,260 mslibcxx CI AIX (32-bit) > ibm-libc++-shared-cfg-in.std/algorithms/alg_modifying_operations/alg_transform::ranges.transform.binary.pass.cpp
1,500,030 mslibcxx CI Apple back-deployment macosx11.0 arm64 > apple-libc++-backdeployment-cfg-in.std/thread/thread_condition::notify_all_at_thread_exit_lwg3343.pass.cpp
1,500,040 mslibcxx CI Apple back-deployment with assertions enabled > apple-libc++-backdeployment-cfg-in.std/thread/thread_condition::notify_all_at_thread_exit_lwg3343.pass.cpp
5,570 mslibcxx CI Clang-cl (no vcruntime exceptions) > llvm-libc++-shared-no-vcruntime-clangcl-cfg-in.std/thread/thread_condition/thread_condition_condvar::notify_all.pass.cpp
13,870 mslibcxx CI Clang-cl (no vcruntime exceptions) > llvm-libc++-shared-no-vcruntime-clangcl-cfg-in.std/thread/thread_mutex/thread_mutex_requirements/thread_sharedtimedmutex_requirements/thread_sharedtimedmutex_class::try_lock_for.pass.cpp
View Full Test Results (6 Failed)

Event Timeline

ldionne created this revision.Jan 26 2023, 11:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 26 2023, 11:47 AM
ldionne requested review of this revision.Jan 26 2023, 11:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 26 2023, 11:47 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik accepted this revision.Jan 26 2023, 11:53 AM
This revision is now accepted and ready to land.Jan 26 2023, 11:53 AM
Harbormaster completed remote builds in B210197: Diff 492539.Jan 26 2023, 12:13 PM
ldionne updated this revision to Diff 493309.Jan 30 2023, 7:06 AM

Remove superfluous <cstddef> include in promote.h, that should fix CI.

Harbormaster completed remote builds in B210777: Diff 493309.Jan 30 2023, 8:31 AM
This revision was landed with ongoing or failed builds.Jan 30 2023, 1:26 PM
Closed by commit rGbab1a14cccd4: [libc++] Add missing include promote.h in <cmath> (authored by ldionne). · Explain Why
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rGbab1a14cccd4: [libc++] Add missing include promote.h in <cmath>.

Revision Contents

PathSize
libcxx/
include/
__type_traits/
1 line
1 line

Diff 493309

libcxx/include/__type_traits/promote.h

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef _LIBCPP___TYPE_TRAITS_PROMOTE_H #ifndef _LIBCPP___TYPE_TRAITS_PROMOTE_H
#define _LIBCPP___TYPE_TRAITS_PROMOTE_H #define _LIBCPP___TYPE_TRAITS_PROMOTE_H
#include <__config> #include <__config>
#include <__type_traits/integral_constant.h> #include <__type_traits/integral_constant.h>
#include <__type_traits/is_same.h> #include <__type_traits/is_same.h>
#include <__utility/declval.h> #include <__utility/declval.h>
#include <cstddef>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
template <class _Tp> template <class _Tp>
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines

libcxx/include/cmath

Show First 20 Lines • Show All 305 Lines • ▼ Show 20 Lines
#include <__assert> // all public C++ headers provide the assertion handler #include <__assert> // all public C++ headers provide the assertion handler
#include <__config> #include <__config>
#include <__type_traits/enable_if.h> #include <__type_traits/enable_if.h>
#include <__type_traits/is_arithmetic.h> #include <__type_traits/is_arithmetic.h>
#include <__type_traits/is_constant_evaluated.h> #include <__type_traits/is_constant_evaluated.h>
#include <__type_traits/is_floating_point.h> #include <__type_traits/is_floating_point.h>
#include <__type_traits/is_same.h> #include <__type_traits/is_same.h>
#include <__type_traits/promote.h>
#include <__type_traits/remove_cv.h> #include <__type_traits/remove_cv.h>
#include <version> #include <version>
#include <math.h> #include <math.h>
#ifndef _LIBCPP_MATH_H #ifndef _LIBCPP_MATH_H
# error <cmath> tried including <math.h> but didn't find libc++'s <math.h> header. \ # error <cmath> tried including <math.h> but didn't find libc++'s <math.h> header. \
This usually means that your header search paths are not configured properly. \ This usually means that your header search paths are not configured properly. \
▲ Show 20 Lines • Show All 515 Lines • Show Last 20 Lines