This is an archive of the discontinued LLVM Phabricator instance.

Fix C++11 warnings in RangeSetTest.cpp
ClosedPublic

Authored by philipp.tomsich on Jan 24 2023, 1:26 AM.

Details

Summary

This change fixes the following warnings:

   llvm/clang/unittests/StaticAnalyzer/RangeSetTest.cpp:727:55: warning: ISO C++11 requires at least one argument for the "..." in a variadic macro
     727 | TYPED_TEST_SUITE(RangeSetCastToNoopTest, NoopCastTypes);
	 |                                                       ^
   llvm/clang/unittests/StaticAnalyzer/RangeSetTest.cpp:728:65: warning: ISO C++11 requires at least one argument for the "..." in a variadic macro
     728 | TYPED_TEST_SUITE(RangeSetCastToPromotionTest, PromotionCastTypes);
	 |                                                                 ^
   llvm/clang/unittests/StaticAnalyzer/RangeSetTest.cpp:729:67: warning: ISO C++11 requires at least one argument for the "..." in a variadic macro
     729 | TYPED_TEST_SUITE(RangeSetCastToTruncationTest, TruncationCastTypes);
	 |                                                                   ^
   llvm/clang/unittests/StaticAnalyzer/RangeSetTest.cpp:730:67: warning: ISO C++11 requires at least one argument for the "..." in a variadic macro
     730 | TYPED_TEST_SUITE(RangeSetCastToConversionTest, ConversionCastTypes);
	 |                                                                   ^
   llvm/clang/unittests/StaticAnalyzer/RangeSetTest.cpp:732:46: warning: ISO C++11 requires at least one argument for the "..." in a variadic macro
     732 |                  PromotionConversionCastTypes);
	 |                                              ^
   llvm/clang/unittests/StaticAnalyzer/RangeSetTest.cpp:734:47: warning: ISO C++11 requires at least one argument for the "..." in a variadic macro
     734 |                  TruncationConversionCastTypes);
	 |                                               ^

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 1:26 AM
Herald added a subscriber: steakhal. · View Herald Transcript
philipp.tomsich requested review of this revision.Jan 24 2023, 1:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 1:26 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
steakhal accepted this revision.Jan 24 2023, 4:36 AM

I'm not that confident around gtest macros, but this doesn't look harmful.
Thanks for taking the time and fixing it.

This revision is now accepted and ready to land.Jan 24 2023, 4:36 AM
This revision was landed with ongoing or failed builds.Jan 24 2023, 1:14 PM
This revision was automatically updated to reflect the committed changes.