This is an archive of the discontinued LLVM Phabricator instance.

[Docs] Mention GitHub commit comments as a possible post-commit review venue
Needs ReviewPublic

Authored by nikic on Jan 24 2023, 1:23 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Mention GitHub commit comments as a possible venue where post-commit review can take place. I believe that commit comments are already being extensively used for this purpose, so this is documenting existing practice.

I've dropped the mention of the development mailing list, because I don't think that's a typical review channel -- it's an escalation route towards the RFC process, but I'd consider that beyond the purview of simple post-commit review.

Diff Detail

Event Timeline

nikic created this revision.Jan 24 2023, 1:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 1:23 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
nikic requested review of this revision.Jan 24 2023, 1:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 1:23 AM

Bugzilla is offline?