Page MenuHomePhabricator

Remove unreachable that was reached in modernize-use-nullptr.
ClosedPublic

Authored by angelgarcia on Nov 2 2015, 5:07 AM.

Details

Summary

When traversing the parent map, the check assumed that all the nodes would be either Stmt or Decl. After r251101, this is no longer true: there can be TypeLoc and NestedNameSpecifierLoc nodes.

Diff Detail

Event Timeline

angelgarcia updated this revision to Diff 38895.Nov 2 2015, 5:07 AM
angelgarcia retitled this revision from to Remove unreachable that was reached in modernize-use-nullptr..
angelgarcia updated this object.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: cfe-commits, klimek.
alexfh accepted this revision.Nov 2 2015, 6:03 AM
alexfh edited edge metadata.

Looks good with one nit.

test/clang-tidy/modernize-use-nullptr.cpp
191

nit: Merge the lines maybe?

This revision is now accepted and ready to land.Nov 2 2015, 6:03 AM
angelgarcia updated this revision to Diff 38918.Nov 2 2015, 7:30 AM
angelgarcia edited edge metadata.

Merge lines.

angelgarcia closed this revision.Nov 2 2015, 7:30 AM