This is an archive of the discontinued LLVM Phabricator instance.

[libc++][NFC] Split up ranges.transform.pass.cpp
ClosedPublic

Authored by philnik on Jan 17 2023, 1:55 PM.

Details

Reviewers
ldionne
Mordante
Group Reviewers
Restricted Project
Commits
rGa331560658cd: [libc++][NFC] Split up ranges.transform.pass.cpp
Summary

ranges.transform.pass.cpp takes ~42s to run on my machine, ranges.transform.binary.pass.cpp takes ~26s and ranges.transform.unary.pass.cpp takes ~2s.

Diff Detail

Event Timeline

philnik created this revision.Jan 17 2023, 1:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2023, 1:55 PM
philnik requested review of this revision.Jan 17 2023, 1:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2023, 1:55 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jan 17 2023, 2:24 PM

Can you comment in the commit message on what impact this has on the compile-time of both? Thanks for doing this BTW!

This revision is now accepted and ready to land.Jan 17 2023, 2:24 PM
philnik edited the summary of this revision. (Show Details)Jan 17 2023, 3:16 PM
This revision was landed with ongoing or failed builds.Jan 17 2023, 5:05 PM
This revision was automatically updated to reflect the committed changes.
libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.binary.pass.cpp