[libc++] Add ALLOW_RETRIES to a few flaky tests

[philnik]

Summary

Fixes #59464

[Mordante]

Thanks for working on this. Did you check whether there are other flacky tests?
LGTM, but make sure the CI is green.

[ldionne]

libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.pass.cpp

1–2 ↗

(On Diff #489671)

This one is not flaky, it's simply too slow. I would instead split it up.

I'd rather not use ALLOW_RETRIES since that isn't what it was meant for -- it was meant to help with tests that are inherently timing-sensitive, not with tests that are just too slow. For example, if ranges.transform.pass.cpp were to fail due to a legitimate problem in the code, it wouldn't make sense to retry it 3 times.

[philnik]

Address comments

[ldionne]

LGTM if this actually helps.

libcxx/test/std/thread/futures/futures.async/async.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: no-threads
 // UNSUPPORTED: c++03
 
+// ALLOW_RETRIES: 3
+
 // <future>
 
 // template <class F, class... Args>
 //     future<typename result_of<F(Args...)>::type>
 //     async(F&& f, Args&&... args);
 
 // template <class F, class... Args>
 //     future<typename result_of<F(Args...)>::type>

libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: no-threads
 
+// ALLOW_RETRIES: 3
+
 // notify_all_at_thread_exit(...) requires move semantics to transfer the unique_lock.
 // UNSUPPORTED: c++03
 
 // This is a regression test for LWG3343.
 //
 // <condition_variable>
 //
 // void notify_all_at_thread_exit(condition_variable& cond, unique_lock<mutex> lk);

libcxx/test/std/thread/thread.mutex/thread.mutex.requirements/thread.sharedtimedmutex.requirements/thread.sharedtimedmutex.class/try_lock_shared_for.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: no-threads
 // UNSUPPORTED: c++03, c++11
 
-// ALLOW_RETRIES: 2
+// ALLOW_RETRIES: 3
 
 // shared_timed_mutex was introduced in macosx10.12
 // UNSUPPORTED: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11}}
 
 // <shared_mutex>
 
 // class shared_timed_mutex;