This is an archive of the discontinued LLVM Phabricator instance.

Differential D141774

[libc++] allow redefined macro in non_trivial_copy_move_ABI test
ClosedPublic

Authored by emaste on Jan 14 2023, 1:03 PM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rG2b91dbae650e: [libc++] allow redefined macro in non_trivial_copy_move_ABI test
Summary

__config defines _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR on FreeBSD, which conflicts with a command-line definition used by the non_trivial_copy_move_ABI test.

Add -Wno-macro-redefined to ADDITIONAL_COMPILE_FLAGS in this test.

Diff Detail

Event Timeline

emaste created this revision.Jan 14 2023, 1:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2023, 1:03 PM
Herald added subscribers: krytarowski, arichardson. · View Herald Transcript
emaste requested review of this revision.Jan 14 2023, 1:03 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 14 2023, 1:03 PM
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik accepted this revision.Jan 14 2023, 3:59 PM
This revision is now accepted and ready to land.Jan 14 2023, 3:59 PM
This revision was landed with ongoing or failed builds.Jan 16 2023, 5:49 AM
Closed by commit rG2b91dbae650e: [libc++] allow redefined macro in non_trivial_copy_move_ABI test (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG2b91dbae650e: [libc++] allow redefined macro in non_trivial_copy_move_ABI test.

Revision Contents

PathSize
libcxx/
test/
libcxx/
utilities/
utility/
pairs/
pairs.pair/
1 line

Diff 489521

libcxx/test/libcxx/utilities/utility/pairs/pairs.pair/non_trivial_copy_move_ABI.pass.cpp

Show All 11 Lines
// <utility> // <utility>
// template <class T1, class T2> struct pair // template <class T1, class T2> struct pair
// Test that we provide the non-trivial copy operations when _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR // Test that we provide the non-trivial copy operations when _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR
// is specified. // is specified.
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR
// ADDITIONAL_COMPILE_FLAGS: -Wno-macro-redefined
#include <utility> #include <utility>
#include <type_traits> #include <type_traits>
#include <cstdlib> #include <cstdlib>
#include <cstddef> #include <cstddef>
#include <cassert> #include <cassert>
#include "test_macros.h" #include "test_macros.h"
▲ Show 20 Lines • Show All 126 Lines • Show Last 20 Lines