This is an archive of the discontinued LLVM Phabricator instance.

Differential D141766

[NFC][libc++] Removes uneeded std:: prefixes.
ClosedPublic

Authored by Mordante on Jan 14 2023, 7:47 AM.

Download Raw Diff

Details

Reviewers

philnik

Group Reviewers

Restricted Project

Commits

rGa518425ddc2a: [NFC][libc++] Removes uneeded std:: prefixes.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	1,500,050 ms	libcxx CI Apple back-deployment with assertions enabled > apple-libc++-backdeployment-cfg-in.std/thread/thread_condition::notify_all_at_thread_exit_lwg3343.pass.cpp

Event Timeline

Mordante created this revision.Jan 14 2023, 7:47 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2023, 7:47 AM

Mordante requested review of this revision.Jan 14 2023, 7:47 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2023, 7:47 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Harbormaster completed remote builds in B207821: Diff 489253.Jan 14 2023, 7:55 AM

Restart CI.

philnik accepted this revision.Jan 14 2023, 7:57 AM

This revision is now accepted and ready to land.Jan 14 2023, 7:57 AM

Restart CI.

Harbormaster completed remote builds in B207835: Diff 489269.Jan 14 2023, 12:00 PM

This revision was landed with ongoing or failed builds.Jan 15 2023, 4:30 AM

Closed by commit rGa518425ddc2a: [NFC][libc++] Removes uneeded std:: prefixes. (authored by Mordante). · Explain Why

This revision was automatically updated to reflect the committed changes.

Mordante added a commit: rGa518425ddc2a: [NFC][libc++] Removes uneeded std:: prefixes..

Revision Contents

Path

Size

libcxx/

include/

vector

4 lines

Diff 489269

libcxx/include/vector

	Show First 20 Lines • Show All 3,298 Lines • ▼ Show 20 Lines
	inline _LIBCPP_HIDE_FROM_ABI typename vector<_Tp, _Allocator>::size_type			inline _LIBCPP_HIDE_FROM_ABI typename vector<_Tp, _Allocator>::size_type
	erase_if(vector<_Tp, _Allocator>& __c, _Predicate __pred) {			erase_if(vector<_Tp, _Allocator>& __c, _Predicate __pred) {
	auto __old_size = __c.size();			auto __old_size = __c.size();
	__c.erase(std::remove_if(__c.begin(), __c.end(), __pred), __c.end());			__c.erase(std::remove_if(__c.begin(), __c.end(), __pred), __c.end());
	return __old_size - __c.size();			return __old_size - __c.size();
	}			}

	template <>			template <>
	inline constexpr bool __format::__enable_insertable<std::vector<char>> = true;			inline constexpr bool __format::__enable_insertable<vector<char>> = true;
	#ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS			#ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS
	template <>			template <>
	inline constexpr bool __format::__enable_insertable<std::vector<wchar_t>> = true;			inline constexpr bool __format::__enable_insertable<vector<wchar_t>> = true;
	#endif			#endif

	#endif // _LIBCPP_STD_VER > 17			#endif // _LIBCPP_STD_VER > 17

	_LIBCPP_END_NAMESPACE_STD			_LIBCPP_END_NAMESPACE_STD

	#if _LIBCPP_STD_VER > 14			#if _LIBCPP_STD_VER > 14
	_LIBCPP_BEGIN_NAMESPACE_STD			_LIBCPP_BEGIN_NAMESPACE_STD
	Show All 18 Lines