[NFC] Makes mutable Function::getBasicBlockList() private

[vporpo]

Summary

Any updates to the BB list should go through the appropriate member functions.

[vporpo]

Rebase

[aeubanks]

llvm/include/llvm/IR/Function.h

730

this is already private?

[vporpo]

llvm/include/llvm/IR/Function.h

730

Oops...

llvm/include/llvm/IR/Function.h

private:
 
   /// Get the underlying elements of the Function... the basic block list is
   /// empty for external functions.
   ///
   /// This is deliberately private because we have implemented an adequate set
   /// of functions to modify the list, including Function::splice(),
   /// Function::erase(), Function::insert() etc.
   const BasicBlockListType &getBasicBlockList() const { return BasicBlocks; }
-        BasicBlockListType &getBasicBlockList()       { return BasicBlocks; }
+
+private:
+  BasicBlockListType &getBasicBlockList() { return BasicBlocks; }
 
+public:
   static BasicBlockListType Function::*getSublistAccess(BasicBlock*) {
     return &Function::BasicBlocks;
   }
 
 public:
   const BasicBlock       &getEntryBlock() const   { return front(); }
         BasicBlock       &getEntryBlock()         { return front(); }