[clang] Add no-argument dump to DynTypedNode

[ccotter]

Summary

Provide a no-argument dump methods to avoid having to do
additional gymnastics to dump a DynTypedNode.

[ccotter]

format

[ccotter]

remove accidental change

[ccotter]

I usually use dump() when authoring/debugging clang-tidy or similar checks. I don't always have ASTContext handy when working with a DynTypedNode (without temporarily changing my call stack to pass the ASTContext around for the purposes of dump).

I put up this as a way of asking whether this kind of change would be considered (just as easy to code this up as ask in Discord etc). Thoughts?

clang/include/clang/AST/ASTTypeTraits.h

 //===--- ASTTypeTraits.h ----------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
public:
   }
 
   /// Prints the node to the given output stream.
   void print(llvm::raw_ostream &OS, const PrintingPolicy &PP) const;
 
   /// Dumps the node to the given output stream.
   void dump(llvm::raw_ostream &OS, const ASTContext &Context) const;
 
+  /// Dumps the node to \c llvm::errs().
+  void dump() const;
+
   /// For nodes which represent textual entities in the source code,
   /// return their SourceRange.  For all other nodes, return SourceRange().
   SourceRange getSourceRange() const;
 
   /// @{
   /// Imposes an order on \c DynTypedNode.
   ///
   /// Supports comparison of nodes that support memoization.

clang/lib/AST/ASTTypeTraits.cpp

 //===--- ASTTypeTraits.cpp --------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
void DynTypedNode::dump(llvm::raw_ostream &OS,
   else if (const Stmt *S = get<Stmt>())
     S->dump(OS, Context);
   else if (const Type *T = get<Type>())
     T->dump(OS, Context);
   else
     OS << "Unable to dump values of type " << NodeKind.asStringRef() << "\n";
 }
 
+void DynTypedNode::dump() const {
+  if (const Decl *D = get<Decl>())
+    D->dump();
+  else if (const Stmt *S = get<Stmt>())
+    S->dump();
+  else if (const Type *T = get<Type>())
+    T->dump();
+  else
+    llvm::errs() << "Unable to dump values of type " << NodeKind.asStringRef()
+                 << "\n";
+}
+
 SourceRange DynTypedNode::getSourceRange() const {
   if (const CXXCtorInitializer *CCI = get<CXXCtorInitializer>())
     return CCI->getSourceRange();
   if (const NestedNameSpecifierLoc *NNSL = get<NestedNameSpecifierLoc>())
     return NNSL->getSourceRange();
   if (const TypeLoc *TL = get<TypeLoc>())
     return TL->getSourceRange();
   if (const Decl *D = get<Decl>())