This is an archive of the discontinued LLVM Phabricator instance.

Differential D141147

[HWASAN] Added empty WordIsPoisoned for LSAN support.
ClosedPublic

Authored by kstoimenov on Jan 6 2023, 10:29 AM.

Details

Reviewers
vitalybuka
thurston
Commits
rGaf12f726a086: [HWASAN] Added empty WordIsPoisoned for LSAN support.
Summary

Currently it is just an empty implementation to allow the project to link.

Diff Detail

Event Timeline

kstoimenov created this revision.Jan 6 2023, 10:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2023, 10:29 AM
Herald added a subscriber: Enna1. · View Herald Transcript
kstoimenov requested review of this revision.Jan 6 2023, 10:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2023, 10:29 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kstoimenov added a child revision: D141143: [HWASAN] Implmented LSAN specifc thread support..Jan 6 2023, 10:29 AM
kstoimenov removed a child revision: D141143: [HWASAN] Implmented LSAN specifc thread support..
kstoimenov added a parent revision: D141143: [HWASAN] Implmented LSAN specifc thread support..
kstoimenov retitled this revision from [HWASAN] Implemented WordIsPoisoned for LSAN support. to [HWASAN] Implemented empty WordIsPoisoned for LSAN support..Jan 6 2023, 10:31 AM
kstoimenov edited the summary of this revision. (Show Details)
kstoimenov removed a parent revision: D141143: [HWASAN] Implmented LSAN specifc thread support..
kstoimenov added a child revision: D141143: [HWASAN] Implmented LSAN specifc thread support..
kstoimenov edited child revisions, added: D140579: [HWASAN] Implemented LSAN in HWASAN.; removed: D141143: [HWASAN] Implmented LSAN specifc thread support..
kstoimenov updated this revision to Diff 486928.Jan 6 2023, 10:35 AM

Added fixme.

kstoimenov added reviewers: vitalybuka, thurston.Jan 6 2023, 10:35 AM
kstoimenov retitled this revision from [HWASAN] Implemented empty WordIsPoisoned for LSAN support. to [HWASAN] Added empty WordIsPoisoned for LSAN support..
Harbormaster completed remote builds in B206157: Diff 486928.Jan 6 2023, 11:12 AM
vitalybuka accepted this revision.Jan 9 2023, 3:21 PM
This revision is now accepted and ready to land.Jan 9 2023, 3:21 PM
Closed by commit rGaf12f726a086: [HWASAN] Added empty WordIsPoisoned for LSAN support. (authored by kstoimenov). · Explain WhyJan 10 2023, 9:36 AM
This revision was automatically updated to reflect the committed changes.
kstoimenov added a commit: rGaf12f726a086: [HWASAN] Added empty WordIsPoisoned for LSAN support..
kstoimenov removed a child revision: D140579: [HWASAN] Implemented LSAN in HWASAN..Jan 10 2023, 4:04 PM

Revision Contents

PathSize
compiler-rt/
lib/
hwasan/
5 lines

Diff 486927

compiler-rt/lib/hwasan/hwasan_poisoning.cpp

Show All 20 Lines
uptr TagMemory(uptr p, uptr size, tag_t tag) { uptr TagMemory(uptr p, uptr size, tag_t tag) {
uptr start = RoundDownTo(p, kShadowAlignment); uptr start = RoundDownTo(p, kShadowAlignment);
uptr end = RoundUpTo(p + size, kShadowAlignment); uptr end = RoundUpTo(p + size, kShadowAlignment);
return TagMemoryAligned(start, end - start, tag); return TagMemoryAligned(start, end - start, tag);
} }
} // namespace __hwasan } // namespace __hwasan
// --- Implementation of LSan-specific functions --- {{{1
namespace __lsan {
bool WordIsPoisoned(uptr addr) { return false; }
} // namespace __lsan