This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Granularize <type_traits> includes in <algorithm>
ClosedPublic

Authored by philnik on Dec 26 2022, 7:24 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rGe698c5950430: [libc++] Granularize <type_traits> includes in <algorithm>

Diff Detail

Event Timeline

philnik created this revision.Dec 26 2022, 7:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 26 2022, 7:24 AM
Herald added a subscriber: wenlei. · View Herald Transcript
philnik requested review of this revision.Dec 26 2022, 7:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 26 2022, 7:24 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante added inline comments.Feb 11 2023, 6:33 AM
libcxx/include/__algorithm/lower_bound.h
23

Interesting to see this header seems not to be needed at all at several places.

libcxx/test/libcxx/transitive_includes/cxx2b.csv
11

Please add this to the release notes.

libcxx/test/std/numerics/bit/bit.endian/endian.pass.cpp
20 ↗(On Diff #496622)

All these changes are unrelated to this patch, right?

philnik updated this revision to Diff 496706.Feb 11 2023, 11:47 AM
philnik marked 3 inline comments as done.

Address comments

libcxx/test/std/numerics/bit/bit.endian/endian.pass.cpp
20 ↗(On Diff #496622)

Yes. Not sure why they are here.

Mordante accepted this revision.Feb 12 2023, 10:27 AM

Thanks for updating, LGTM!

This revision is now accepted and ready to land.Feb 12 2023, 10:27 AM
This revision was landed with ongoing or failed builds.Feb 13 2023, 4:21 AM
This revision was automatically updated to reflect the committed changes.