This is an archive of the discontinued LLVM Phabricator instance.

[include-cleaner] Respect IWYU pragmas during analyze
ClosedPublic

Authored by kadircet on Dec 20 2022, 1:42 AM.

Diff Detail

Event Timeline

kadircet created this revision.Dec 20 2022, 1:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 20 2022, 1:42 AM
kadircet requested review of this revision.Dec 20 2022, 1:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 20 2022, 1:42 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
kadircet edited the summary of this revision. (Show Details)Dec 20 2022, 1:47 AM
hokein accepted this revision.Dec 20 2022, 1:52 AM
hokein added inline comments.
clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp
184

add the export case as well.

This revision is now accepted and ready to land.Dec 20 2022, 1:52 AM
kadircet added inline comments.Dec 20 2022, 1:53 AM
clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp
184

i don't think we should be testing the behaviour of PragmaIncludes::shouldKeep here, hence i think one example is enough.

This revision was landed with ongoing or failed builds.Dec 20 2022, 1:54 AM
This revision was automatically updated to reflect the committed changes.